public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org, mochel@osdl.org
Subject: Re: [PATCH] Make pmdisk suspend more reliable
Date: Sun, 12 Oct 2003 20:07:03 +0200	[thread overview]
Message-ID: <20031012180703.GA2328@mars.ravnborg.org> (raw)
In-Reply-To: <20031012161828.GA1728@atomide.com>

On Sun, Oct 12, 2003 at 09:18:28AM -0700, Tony Lindgren wrote:

> --- linux-2.6.0-test7/kernel/power/pmdisk.c-orig	2003-10-12 18:35:58.000000000 +0300
> +++ linux-2.6.0-test7/kernel/power/pmdisk.c	2003-10-12 19:00:32.000000000 +0300
> @@ -35,6 +35,7 @@
>  
>  
>  extern int pmdisk_arch_suspend(int resume);
> +extern int wakeup_bdflush(long nr_pages);

Prototypes in .c files is never a good idea.
wakeup_bdflush is prototyped in include/linux/writeback.h

pmdisk_arch_suspend is expected to be implemented in assembler, which
explain why it is prototypes locally.

	Sam

  reply	other threads:[~2003-10-12 18:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-12 16:18 [PATCH] Make pmdisk suspend more reliable Tony Lindgren
2003-10-12 18:07 ` Sam Ravnborg [this message]
2003-10-14 15:19   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031012180703.GA2328@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox