From: Tony Lindgren <tony@atomide.com>
To: linux-kernel@vger.kernel.org, mochel@osdl.org
Subject: Re: [PATCH] Make pmdisk suspend more reliable
Date: Tue, 14 Oct 2003 08:19:50 -0700 [thread overview]
Message-ID: <20031014151950.GA11710@atomide.com> (raw)
In-Reply-To: <20031012180703.GA2328@mars.ravnborg.org>
Hi,
* Sam Ravnborg <sam@ravnborg.org> [031012 11:07]:
> On Sun, Oct 12, 2003 at 09:18:28AM -0700, Tony Lindgren wrote:
>
> > extern int pmdisk_arch_suspend(int resume);
> > +extern int wakeup_bdflush(long nr_pages);
>
> Prototypes in .c files is never a good idea.
> wakeup_bdflush is prototyped in include/linux/writeback.h
I guess you mean to #include <linux/writeback.h> instead of extern, or
did I misunderstand what you meant?
There may be more to the suspend image not getting to the disk besides
flushing, I'm now wondering if it works with IDE DMA enabled, but not
without DMA. I'll try to investigate it a bit further.
Tony
prev parent reply other threads:[~2003-10-14 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-12 16:18 [PATCH] Make pmdisk suspend more reliable Tony Lindgren
2003-10-12 18:07 ` Sam Ravnborg
2003-10-14 15:19 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031014151950.GA11710@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox