2.6.0-test7 USB and Palm Tungsten problem

2.6.0-test7 USB and Palm Tungsten problem

[Tomas Konir]

Hi
I tried 2.6.0-test7, but new USB problem found. I tried to synchronize the 
palm Tungsten T over USB cradle. None happend, only short message about 
palm connected in log. Plug out the palm, but the visor module remained 
busy (count=1) and when i tried to rmmod uhci-hcd the rmmod stay in D 
state.

	MOJE


Loaded modules:

visor
usbserial
uhci-hcd
usbcore

end of dmesg:
only last important lines (i hope)

usbserial 1-1:1.0: usb_probe_interface
usbserial 1-1:1.0: usb_probe_interface - got id
drivers/usb/core/usb.c: registered new driver usbserial
drivers/usb/serial/usb-serial.c: USB Serial Driver core v2.0
drivers/usb/serial/usb-serial.c: USB Serial support registered for 
Handspring Visor / Palm OS
drivers/usb/serial/usb-serial.c: USB Serial support registered for Sony 
Clie 3.5
drivers/usb/core/usb.c: registered new driver visor
drivers/usb/serial/visor.c: USB HandSpring Visor / Palm OS driver v2.1
hub 1-0:1.0: port 2, status 101, change 1, 12 Mb/s
hub 1-0:1.0: debounce: port 2: delay 100ms stable 4 status 0x101
hub 1-0:1.0: new USB device on port 2, assigned address 3
usb 1-2: new device strings: Mfr=1, Product=2, SerialNumber=5
drivers/usb/core/message.c: USB device number 3 default language ID 0x409
usb 1-2: Product: Palm Handheld
usb 1-2: Manufacturer: Palm, Inc.
usb 1-2: SerialNumber: 303054465042503241434B48
usb 1-2: registering 1-2:1.0 (config #1, interface 0)
usbserial 1-2:1.0: usb_probe_interface
usbserial 1-2:1.0: usb_probe_interface - got id



-- 
Konir Tomas
Czech Republic
Brno
ICQ 25849167

Re: 2.6.0-test7 USB and Palm Tungsten problem

[Greg KH]

On Mon, Oct 13, 2003 at 07:06:49PM -0400, Tomas Konir wrote:
> 
> Hi
> I tried 2.6.0-test7, but new USB problem found. I tried to synchronize the 
> palm Tungsten T over USB cradle. None happend, only short message about 
> palm connected in log. Plug out the palm, but the visor module remained 
> busy (count=1) and when i tried to rmmod uhci-hcd the rmmod stay in D 
> state.

Try the patch below.  It should fix the problem for you.  If not, please
let me know.

thanks,

greg k-h


# USB: fix visor driver to work with Palm OS 4+ devices
# For some reason, they do not like the reset_config calls anymore.

diff -Nru a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
--- a/drivers/usb/serial/visor.c	Mon Oct 13 12:45:25 2003
+++ b/drivers/usb/serial/visor.c	Mon Oct 13 12:45:25 2003
@@ -778,9 +778,6 @@
 			serial->dev->actconfig->desc.bConfigurationValue);
 		return -ENODEV;
 	}
-	dbg("%s - reset config", __FUNCTION__);
-	retval = usb_reset_configuration (serial->dev);
-
 
 	if (id->driver_info) {
 		startup = (void *)id->driver_info;

Re: 2.6.0-test7 USB and Palm Tungsten problem

[cliff white]

On Mon, 13 Oct 2003 12:46:16 -0700
Greg KH <greg@kroah.com> wrote:

> On Mon, Oct 13, 2003 at 07:06:49PM -0400, Tomas Konir wrote:
> > 
> > Hi
> > I tried 2.6.0-test7, but new USB problem found. I tried to synchronize the 
> > palm Tungsten T over USB cradle. None happend, only short message about 
> > palm connected in log. Plug out the palm, but the visor module remained 
> > busy (count=1) and when i tried to rmmod uhci-hcd the rmmod stay in D 
> > state.
> 
> Try the patch below.  It should fix the problem for you.  If not, please
> let me know.
> 

This fixes the HotSync problem i reported on the Sony CLIE PEG-SJ22
thanks!
cliffw


> thanks,
> 
> greg k-h
> 
> 
> # USB: fix visor driver to work with Palm OS 4+ devices
> # For some reason, they do not like the reset_config calls anymore.
> 
> diff -Nru a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
> --- a/drivers/usb/serial/visor.c	Mon Oct 13 12:45:25 2003
> +++ b/drivers/usb/serial/visor.c	Mon Oct 13 12:45:25 2003
> @@ -778,9 +778,6 @@
>  			serial->dev->actconfig->desc.bConfigurationValue);
>  		return -ENODEV;
>  	}
> -	dbg("%s - reset config", __FUNCTION__);
> -	retval = usb_reset_configuration (serial->dev);
> -
>  
>  	if (id->driver_info) {
>  		startup = (void *)id->driver_info;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: 2.6.0-test7 USB and Palm Tungsten problem

[Tomas Konir]

On Mon, 13 Oct 2003, Greg KH wrote:

> On Mon, Oct 13, 2003 at 07:06:49PM -0400, Tomas Konir wrote:
> > 
> > Hi
> > I tried 2.6.0-test7, but new USB problem found. I tried to synchronize the 
> > palm Tungsten T over USB cradle. None happend, only short message about 
> > palm connected in log. Plug out the palm, but the visor module remained 
> > busy (count=1) and when i tried to rmmod uhci-hcd the rmmod stay in D 
> > state.
> 
> Try the patch below.  It should fix the problem for you.  If not, please
> let me know.
> 

It works
thank you.

	MOJE


-- 
Konir Tomas
Czech Republic
Brno
ICQ 25849167