From: Jens Axboe <axboe@suse.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linus Torvalds <torvalds@osdl.org>,
Christoph Hellwig <hch@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [SCSI] Set max_phys_segments to sg_tablesize
Date: Wed, 15 Oct 2003 14:02:59 +0200 [thread overview]
Message-ID: <20031015120259.GC1077@suse.de> (raw)
In-Reply-To: <20031015115740.GA23469@gondor.apana.org.au>
On Wed, Oct 15 2003, Herbert Xu wrote:
> Hi:
>
> Many SCSI host drivers assume that use_sg will be <= sg_tablesize.
> Hence they may break under 2.6 as the number of physical segments
> is not limited by sg_tablesize. This patch fixes that.
Is sg_tablesize guarenteed to be set? Looks like you need a
===== drivers/scsi/hosts.c 1.94 vs edited =====
--- 1.94/drivers/scsi/hosts.c Sun Sep 21 19:52:38 2003
+++ edited/drivers/scsi/hosts.c Wed Oct 15 14:02:14 2003
@@ -234,7 +234,11 @@
shost->hostt = sht;
shost->this_id = sht->this_id;
shost->can_queue = sht->can_queue;
+
shost->sg_tablesize = sht->sg_tablesize;
+ if (!shost->sg_tablesize)
+ shost->sg_tablesize = MAX_PHYS_SEGMENTS;
+
shost->cmd_per_lun = sht->cmd_per_lun;
shost->unchecked_isa_dma = sht->unchecked_isa_dma;
shost->use_clustering = sht->use_clustering;
additionally.
--
Jens Axboe
next prev parent reply other threads:[~2003-10-15 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-15 11:57 [SCSI] Set max_phys_segments to sg_tablesize Herbert Xu
2003-10-15 12:02 ` Jens Axboe [this message]
2003-10-15 12:06 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2003-10-15 12:14 mika.penttila
2003-10-15 12:31 ` Herbert Xu
2003-10-15 12:37 mika.penttila
2003-10-16 4:51 ` David S. Miller
2003-10-16 6:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031015120259.GC1077@suse.de \
--to=axboe@suse.de \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox