From: Jens Axboe <axboe@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: mika.penttila@kolumbus.fi, herbert@gondor.apana.org.au,
torvalds@osdl.org, hch@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [SCSI] Set max_phys_segments to sg_tablesize
Date: Thu, 16 Oct 2003 08:57:43 +0200 [thread overview]
Message-ID: <20031016065743.GG1128@suse.de> (raw)
In-Reply-To: <20031015215134.6f5a0479.davem@redhat.com>
On Wed, Oct 15 2003, David S. Miller wrote:
> On Wed, 15 Oct 2003 15:37:22 +0300
> <mika.penttila@kolumbus.fi> wrote:
>
> > >It does matter if the driver can't cope with it.
> >
> > But this fix may hurt performance with well behaving drivers in
> > iommu systems. It's better to fix the broken drivers I think.
>
> That's absolutely correct.
>
> If you add Herbert's change, you will effectively turn off all
> of the IOMMU coalescing benefits we designed into the block layer.
> Please don't apply it, fix the broken drivers instead.
Just changing it to hw segments should be fine, but I agree phys
segments is the wrong check.
--
Jens Axboe
next prev parent reply other threads:[~2003-10-16 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-15 12:37 [SCSI] Set max_phys_segments to sg_tablesize mika.penttila
2003-10-16 4:51 ` David S. Miller
2003-10-16 6:57 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-10-15 12:14 mika.penttila
2003-10-15 12:31 ` Herbert Xu
2003-10-15 11:57 Herbert Xu
2003-10-15 12:02 ` Jens Axboe
2003-10-15 12:06 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031016065743.GG1128@suse.de \
--to=axboe@suse.de \
--cc=davem@redhat.com \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@kolumbus.fi \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox