[PATCH] Fix a problem with 8250 UARTs on PPC

[PATCH] Fix a problem with 8250 UARTs on PPC

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

Hello.  As part of the patch I sent that went into 2.6.0-test7 (Nat Semi
SuperI/O chips on PPCs at least have a number of different divisors),
the following should have been done as well, but wasn't.  If we don't
change the divisor, we don't want to change what we claim as the uart
clock either.  Without this I don't get a usable serial console on my
Motorola Sandpoint.

--- 1.41/drivers/serial/8250.c	Tue Oct 21 22:10:07 2003
+++ edited/drivers/serial/8250.c	Fri Dec 12 11:57:13 2003
@@ -530,10 +530,10 @@
 			status1 |= 0x10;  /* 1.625 divisor for baud_base --> 921600 */
 			serial_outp(up, 0x04, status1);
 			serial_outp(up, UART_LCR, 0);
+			up->port.uartclk = 921600*16;
 #endif
 
 			up->port.type = PORT_NS16550A;
-			up->port.uartclk = 921600*16;
 			return;
 		}
 	}

-- 
Tom Rini
http://gate.crashing.org/~trini/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] Fix a problem with 8250 UARTs on PPC

[Russell King]

On Fri, Dec 12, 2003 at 12:00:12PM -0700, Tom Rini wrote:
> Hello.  As part of the patch I sent that went into 2.6.0-test7 (Nat Semi
> SuperI/O chips on PPCs at least have a number of different divisors),
> the following should have been done as well, but wasn't.  If we don't
> change the divisor, we don't want to change what we claim as the uart
> clock either.  Without this I don't get a usable serial console on my
> Motorola Sandpoint.

Thanks, applied.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core