Re: kgdb for mainline kernel: core-lite [patch 1/3]

[Andrew Morton <akpm@osdl.org>]

"Amit S. Kale" <amitkale@emsyssoft.com> wrote:
>
> Here is the intrusive piece of code that helps get thread state correctly. Any 
>  ideas on cleaning it?

I think George's stub has diverged rather a lot from yours.  Much more than
I was aware.


>  --- linux-2.6.3-kgdb.orig/include/linux/sched.h	2004-02-24 10:44:47.000000000 
>  +0530
>  +++ linux-2.6.3-kgdb/include/linux/sched.h	2004-03-04 18:42:56.324188184 +0530
>  @@ -173,7 +173,9 @@
>   
>   #define	MAX_SCHEDULE_TIMEOUT	LONG_MAX
>   extern signed long FASTCALL(schedule_timeout(signed long timeout));
>  -asmlinkage void schedule(void);
>  +asmlinkage void do_schedule(void);
>  +asmlinkage void kern_schedule(void);
>  +asmlinkage void kern_do_schedule(struct pt_regs);

The stub in -mm has only a single change to sched.c:

diff -puN kernel/sched.c~kgdb-ga kernel/sched.c
--- 25/kernel/sched.c~kgdb-ga	2004-03-07 01:57:48.000000000 -0800
+++ 25-akpm/kernel/sched.c	2004-03-07 01:57:48.000000000 -0800
@@ -2015,6 +2015,13 @@ out_unlock:
 
 EXPORT_SYMBOL(set_user_nice);
 
+#if defined( CONFIG_KGDB)
+struct task_struct * kgdb_get_idle(int this_cpu)
+{
+        return cpu_rq(this_cpu)->idle;
+}
+#endif
+
 #ifndef __alpha__
 
 /*