From: Andrea Arcangeli <andrea@suse.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.5-aa1 arch updates
Date: Sun, 4 Apr 2004 17:49:24 +0200 [thread overview]
Message-ID: <20040404154924.GD2164@dualathlon.random> (raw)
In-Reply-To: <Pine.LNX.4.44.0404041446430.22502-100000@localhost.localdomain>
On Sun, Apr 04, 2004 at 02:48:15PM +0100, Hugh Dickins wrote:
> I've gone through our arch and include/asm files checking differences,
> here's a patch to 2.6.5-aa1: page_mapping(page) and prio_tree updates.
> All uncompiled and untested, but probably better than certainly wrong.
>
> One fix: your ppc64 pte_alloc_one forgot to return NULL on failure:
> I notice that's a __GFP_REPEAT allocation, but even those fail when
> OOM-killed - I find its alias __GFP_NOFAIL very misleading.
this is greatly appreciated, thanks!
> I forget where you stand now on the ppc pgtable stuff: it naturally
> shows up here again, ignore again if you're sure it's irrelevant.
I'm unsure about the arch/ppc/mm/pgtable.c part, I mean, ppc is being
tested heavily, how can it be necessary if nobody ever got an oops yet?
OTOH your patch certainly cannot hurt and it might be needed after all.
Maybe I should apply it after all, it'd be nice to get a comment on this
bit from ppc people who knows tlb.c better to be sure.
The rest is definitely necessary of course (especially the return NULL
on ppc64 ;).
next prev parent reply other threads:[~2004-04-04 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-04 13:48 [PATCH] 2.6.5-aa1 arch updates Hugh Dickins
2004-04-04 15:49 ` Andrea Arcangeli [this message]
2004-04-04 22:30 ` Paul Mackerras
2004-04-04 23:09 ` Andrea Arcangeli
2004-04-04 21:51 ` Andrew Morton
2004-04-04 22:10 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040404154924.GD2164@dualathlon.random \
--to=andrea@suse.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox