Re: [PATCH] 2.6.5-aa1 arch updates

[Andrea Arcangeli <andrea@suse.de>]

On Mon, Apr 05, 2004 at 08:30:57AM +1000, Paul Mackerras wrote:
> Andrea Arcangeli writes:
> 
> > I'm unsure about the arch/ppc/mm/pgtable.c part, I mean, ppc is being
> > tested heavily, how can it be necessary if nobody ever got an oops yet? 
> > OTOH your patch certainly cannot hurt and it might be needed after all.
> > Maybe I should apply it after all, it'd be nice to get a comment on this
> > bit from ppc people who knows tlb.c better to be sure.
> 
> We definitely need page->mapping and page->index set on pte and pmd
> pages, both on ppc and ppc64.  Otherwise the flush_tlb_* functions
> won't work properly.  Hugh's patch looks good to me (at least as far
> as the ppc/ppc64 bits are concerned).

ok thanks, Hugh's arch's update adding ppc support are fully applied
right now in 2.6-aa and all other relevant trees. Thanks again Hugh!

I only still wonder how this could be unnoticed in practice in ppc(32)?
I mean page->mapping should be NULL if we don't set it and it should
cause an oops in flush_hash_one_pte, no? (if Hash != 0 of course)