* [PATCH] Oprofilefs cant handle > 99 cpus
@ 2004-04-18 11:06 Anton Blanchard
2004-04-18 16:37 ` Philippe Elie
2004-04-19 10:06 ` Jan-Benedict Glaw
0 siblings, 2 replies; 3+ messages in thread
From: Anton Blanchard @ 2004-04-18 11:06 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, oprofile-list
Hi,
Oprofilefs cant handle > 99 cpus. This should fix it.
Anton
===== oprofile_stats.c 1.6 vs edited =====
--- 1.6/drivers/oprofile/oprofile_stats.c Mon Jan 19 17:33:51 2004
+++ edited/oprofile_stats.c Sun Apr 18 19:46:35 2004
@@ -55,7 +55,7 @@
continue;
cpu_buf = &cpu_buffer[i];
- snprintf(buf, 6, "cpu%d", i);
+ snprintf(buf, 10, "cpu%d", i);
cpudir = oprofilefs_mkdir(sb, dir, buf);
/* Strictly speaking access to these ulongs is racy,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Oprofilefs cant handle > 99 cpus
2004-04-18 11:06 [PATCH] Oprofilefs cant handle > 99 cpus Anton Blanchard
@ 2004-04-18 16:37 ` Philippe Elie
2004-04-19 10:06 ` Jan-Benedict Glaw
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Elie @ 2004-04-18 16:37 UTC (permalink / raw)
To: Anton Blanchard; +Cc: akpm, linux-kernel, oprofile-list
On Sun, 18 Apr 2004 at 21:06 +0000, Anton Blanchard wrote:
>
> Hi,
>
> Oprofilefs cant handle > 99 cpus. This should fix it.
right.
> ===== oprofile_stats.c 1.6 vs edited =====
> --- 1.6/drivers/oprofile/oprofile_stats.c Mon Jan 19 17:33:51 2004
> +++ edited/oprofile_stats.c Sun Apr 18 19:46:35 2004
> @@ -55,7 +55,7 @@
> continue;
>
> cpu_buf = &cpu_buffer[i];
> - snprintf(buf, 6, "cpu%d", i);
> + snprintf(buf, 10, "cpu%d", i);
> cpudir = oprofilefs_mkdir(sb, dir, buf);
>
> /* Strictly speaking access to these ulongs is racy,
Andrew, can you apply this patch ?
regards,
Phil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Oprofilefs cant handle > 99 cpus
2004-04-18 11:06 [PATCH] Oprofilefs cant handle > 99 cpus Anton Blanchard
2004-04-18 16:37 ` Philippe Elie
@ 2004-04-19 10:06 ` Jan-Benedict Glaw
1 sibling, 0 replies; 3+ messages in thread
From: Jan-Benedict Glaw @ 2004-04-19 10:06 UTC (permalink / raw)
To: linux-kernel
On Sun, 2004-04-18 21:06:58 +1000, Anton Blanchard <anton@samba.org>
wrote in message <20040418110658.GC26086@krispykreme>:
> Oprofilefs cant handle > 99 cpus. This should fix it.
Erm, on what hardware are you testing? Some large POWER5 machine?
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg
fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak!
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-04-19 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-18 11:06 [PATCH] Oprofilefs cant handle > 99 cpus Anton Blanchard
2004-04-18 16:37 ` Philippe Elie
2004-04-19 10:06 ` Jan-Benedict Glaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox