Re: [PATCH 2.4] jffs2 aligment problems

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Mon, Jun 07, 2004 at 09:03:07AM -0700, Linus Torvalds wrote:
> On Mon, 7 Jun 2004, Thomas Gleixner wrote:
> >
> > On Monday 07 June 2004 17:08, Greg Weeks wrote:
> > > This fixed some jffs2 alignment problems we saw on an IXP425 based
> > > XScale board. I just got pinged that I was supposed to post this patch
> > > in case anyone else finds it usefull. This was against a modified 2.4.19
> > > kernel.
> > 
> > Enable CONFIG_ALIGNMENT_TRAP instead of tweaking the code. 
> > JFFS2 / MTD must be allowed to do unaligned access
> 
> Wrong.
> 
> Pleas fix jffs2 to use the proper "get_unaligned()"/"put_unaligned()"
> instead.
> 
> Emulating unaligned accesses with traps (even even the architecture
> supports it, which isn't universally true) is _stupid_ when we have
> perfectly well-defined macros for them that do it faster and are
> _designed_ for this.
> 
> On architectures where it doesn't matter, the macros just do the access,
> so it's not like you're slowing anything down.
> 
> 		Linus

I'll let you have a bun fight with dwmw2 and networking people over
this.  I'm standing well clear. 8)

[Added dwmw2 and dropped linux-arm-kernel]

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core