From: "Thomas Gleixner" <tglx@linutronix.de>
To: Linus Torvalds <torvalds@osdl.org>,
David Woodhouse <dwmw2@infradead.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Greg Weeks <greg.weeks@timesys.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.4] jffs2 aligment problems
Date: Mon, 7 Jun 2004 22:56:46 +0200 [thread overview]
Message-ID: <200406072256.46952.tglx@linutronix.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0406071351450.1637@ppc970.osdl.org>
On Monday 07 June 2004 22:54, Linus Torvalds wrote:
> On Mon, 7 Jun 2004, David Woodhouse wrote:
> > On Mon, 2004-06-07 at 12:22 -0700, Linus Torvalds wrote:
> > > I don't see it as a correctness issue, I see it as a performance issue.
> >
> > In the case in question it's very much _not_ a performance issue. We're
> > writing a buffer to FLASH memory. The time it takes to read the word
> > from RAM is entirely lost in the noise compared with the time it takes
> > to write it to the flash.
>
> Not if you have to take an alignment fault, which is easily several
> thousand cycles.
>
> Think of "get_unaligned()" as a worst-case limiter. It can make the best
> case be worse on architectures where it matters, but it can make the worst
> case go from thousands of cycles to just single cycles.
>
> And your flash isn't _that_ slow. Thousands of cycles that can't even
> overlap with any flash IO _does_ show up.
Not the IO write to the FLASH is the slow and noisy part, its the programming
of the FLASH after writing the data which blocks for a non deteministic time
in the range of milliseconds.
So we did not care if it took ms + x µs due to an alignement trap
--
Thomas
________________________________________________________________________
Steve Ballmer quotes the statistic that IT pros spend 70 percent of their
time managing existing systems. That couldn’t have anything to do with
the fact that 99 percent of these systems run Windows, could it?
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de
next prev parent reply other threads:[~2004-06-07 21:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-07 15:08 [PATCH 2.4] jffs2 aligment problems Greg Weeks
2004-06-07 15:36 ` Thomas Gleixner
2004-06-07 16:03 ` Linus Torvalds
2004-06-07 16:41 ` Russell King
2004-06-07 19:14 ` David Woodhouse
2004-06-07 19:22 ` Linus Torvalds
2004-06-07 20:39 ` David Woodhouse
2004-06-07 20:54 ` Linus Torvalds
2004-06-07 20:56 ` Thomas Gleixner [this message]
2004-06-07 21:29 ` David Woodhouse
2004-06-07 21:40 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406072256.46952.tglx@linutronix.de \
--to=tglx@linutronix.de \
--cc=dwmw2@infradead.org \
--cc=greg.weeks@timesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox