Re: [PATCH] IDE update for 2.6.7-rc3 [1/12]

[Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>]

On Sunday 13 of June 2004 10:35, Herbert Xu wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
> > On Fri, Jun 11, 2004 at 05:50:30PM +0200, Bartlomiej Zolnierkiewicz wrote:
> >> Probably some drivers are still missed because I changed only
> >> these drivers that I knew that there are PCI cards using them.
> >>
> >> If you know about PCI cards using other drivers please speak up.
> >
> > IMHO the PCI ->probe methods should always be __devinit.  It's rather
> > hard to make sure they're never every hotplugged in any way, especially
> > with the dynamic id adding via sysfs thing.
>
> Well the reason I made them all __devinit in my patch is because it
> also tries to maintain the same PCI probing order as a builtin kernel
> when IDE is built as a module.
>
> To do that all the PCI driver modules are loaded before probing takes
> place.  Therefore if any probing funciton is declared as __init then
> this will not work.

This makes ordering of IDE devices different in Debian-2.6
and vanilla 2.4/2.6, doesn't sound like a good thing to do.

Ideally ordering should be controlled by user-space. :-)

BTW ide-generic.c is a very wrong place to add ide_scan_pcibus() call

Cheers.

> Cheers,