From: Christoph Hellwig <hch@infradead.org>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IDE update for 2.6.7-rc3 [1/12]
Date: Mon, 14 Jun 2004 10:58:35 +0100 [thread overview]
Message-ID: <20040614095835.GA11585@infradead.org> (raw)
In-Reply-To: <200406131936.08338.bzolnier@elka.pw.edu.pl>
On Sun, Jun 13, 2004 at 07:36:08PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > IMHO the PCI ->probe methods should always be __devinit. It's rather
> > hard to make sure they're never every hotplugged in any way, especially
> > with the dynamic id adding via sysfs thing.
>
> I generally agree but IMO it makes no sense for i.e. piix.c.
Are you sure? I've seen piix3/4 in very strange place, iirc even in
a docking station which is hotpluggable.
And even if for this special hardware it's usually not doable there
are things like greg's fake hotplug pci driver. So a non-__devinit pci
probe method is a bug, please fix them in PCI.
next prev parent reply other threads:[~2004-06-14 9:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-11 15:50 [PATCH] IDE update for 2.6.7-rc3 [1/12] Bartlomiej Zolnierkiewicz
2004-06-12 10:34 ` Christoph Hellwig
2004-06-13 8:35 ` Herbert Xu
2004-06-13 18:01 ` Bartlomiej Zolnierkiewicz
2004-06-13 22:18 ` Herbert Xu
2004-06-14 14:37 ` Bartlomiej Zolnierkiewicz
2004-06-14 21:29 ` Herbert Xu
2004-06-13 17:36 ` Bartlomiej Zolnierkiewicz
2004-06-14 9:58 ` Christoph Hellwig [this message]
2004-06-14 14:36 ` Bartlomiej Zolnierkiewicz
2004-06-14 14:44 ` Christoph Hellwig
2004-06-14 15:00 ` dwm
2004-06-14 15:54 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040614095835.GA11585@infradead.org \
--to=hch@infradead.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox