public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: linux-kernel@vger.kernel.org
Subject: [4/12] unregister driver if probing fails in sb_card.c
Date: Sun, 13 Jun 2004 17:37:08 -0700	[thread overview]
Message-ID: <20040614003708.GS1444@holomorphy.com> (raw)
In-Reply-To: <20040614003605.GR1444@holomorphy.com>

 * Unregister driver if probing fails in sound/oss/sb_card.c
This fixes Debian BTS #218845.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=218845

	From: Robin Gerard <robin.jag@free.fr>
	To: submit@bugs.debian.org
	Subject: no sound with kernel-image-2.6.0-test9-1-386
	Message-ID: <20031103004939.GA2071@mauritius>

I downlaoded the kernel-image-2.6.0-test9-1-386_2.6.0-test9-1_i386.deb
and I installed it successfully. Everything works fine, except the sound.
(I run also the kernel-image-2.4.20 and the sound is ok with this kernel)
My sound card is a sb.

First I launched modconf but no module was displayed.

I did: modprobe sb=20
and I got:

sb: Init: Done
sb: Init: Starting Probe...
kobject_register failed for OSS SndBlstr (-17)
Call Trace:
[<c0191cda>] kobject_register+0x3a/0x40
[<c01d9bcc>] bus_add_driver+0x30/0x64
[<c01d9e51>] driver_register+0x2d/0x34
[<c011a24a>] preempt_schedule+0x2a/0x48
[<c01b6f84>] pnp_register_driver+0x28/0x58
[<c01b6c5e>] pnp_register_card_driver+0x5e/0x98
[<c488f063>] sb_init+0x63/0xb5 [sb]
[<c0130bf4>] sys_init_module+0xe8/0x1f0
[<c010b577>] syscall_call+0x7/0xb


Index: linux-2.5/sound/oss/sb_card.c
===================================================================
--- linux-2.5.orig/sound/oss/sb_card.c	2004-06-13 11:57:56.000000000 -0700
+++ linux-2.5/sound/oss/sb_card.c	2004-06-13 12:08:55.000000000 -0700
@@ -309,7 +309,13 @@
 
 	/* If either PnP or Legacy registered a card then return
 	 * success */
-	return (pres > 0 || lres > 0) ? 0 : -ENODEV;
+	if (pres <= 0 && lres <= 0) {
+#ifdef CONFIG_PNP
+		pnp_unregister_card_driver(&sb_pnp_driver);
+#endif
+		return -ENODEV;
+	}
+	return 0;
 }
 
 static void __exit sb_exit(void)

  reply	other threads:[~2004-06-14  0:37 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-14  0:31 [0/12] Debian bugfixes William Lee Irwin III
2004-06-14  0:33 ` [1/12] don't dereference netdev->name before register_netdev() William Lee Irwin III
2004-06-14  0:34   ` [2/12] lower priority of "too many keys" msg in atkbd.c William Lee Irwin III
2004-06-14  0:36     ` [3/12] remove irda usage of isa_virt_to_bus() William Lee Irwin III
2004-06-14  0:37       ` William Lee Irwin III [this message]
2004-06-14  0:38         ` [5/12] Ignore errors from tw_setfeature in 3w-xxxx.c William Lee Irwin III
2004-06-14  0:39           ` [6/12] fix advansys.c highmem bugs William Lee Irwin III
2004-06-14  0:40             ` [7/12] Handle NO_SENSE in sd_rw_intr in sd.c William Lee Irwin III
2004-06-14  0:41               ` [8/12] fake inquiry for Sony Clie PEG-TJ25 in unusual_devs.h William Lee Irwin III
2004-06-14  0:43                 ` [9/12] fix duplicate environment variables passed to init William Lee Irwin III
2004-06-14  0:45                   ` [10/12] fix handling of '/' embedded in filenames in isofs William Lee Irwin III
2004-06-14  0:47                     ` [11/12] fix isofs ignoring noexec and mode mount options William Lee Irwin III
2004-06-14  0:48                       ` [12/12] fix thread_info.h ignoring __HAVE_THREAD_FUNCTIONS William Lee Irwin III
2004-06-14  8:16                         ` Christoph Hellwig
2004-06-14  8:34                           ` William Lee Irwin III
2004-06-14 10:19                           ` Roman Zippel
2004-06-14 10:23                             ` Christoph Hellwig
2004-06-14 10:47                               ` Roman Zippel
2004-06-14  8:15                     ` [10/12] fix handling of '/' embedded in filenames in isofs Christoph Hellwig
2004-06-14  8:14                 ` [8/12] fake inquiry for Sony Clie PEG-TJ25 in unusual_devs.h Christoph Hellwig
2004-06-14  8:14               ` [7/12] Handle NO_SENSE in sd_rw_intr in sd.c Christoph Hellwig
2004-06-14  4:26             ` [6/12] fix advansys.c highmem bugs Andrew Morton
2004-06-14  8:11               ` William Lee Irwin III
2004-06-14  8:13             ` Christoph Hellwig
2004-06-14  8:12           ` [5/12] Ignore errors from tw_setfeature in 3w-xxxx.c Christoph Hellwig
2004-06-14  8:11       ` [3/12] remove irda usage of isa_virt_to_bus() Christoph Hellwig
2004-06-14  8:11     ` [2/12] lower priority of "too many keys" msg in atkbd.c Christoph Hellwig
2004-06-14  4:14   ` [1/12] don't dereference netdev->name before register_netdev() Andrew Morton
2004-06-14  4:27   ` Jeff Garzik
2004-06-14  5:26     ` Herbert Xu
2004-06-14  8:21       ` William Lee Irwin III
2004-06-14  8:10   ` Christoph Hellwig
2004-06-14  8:22     ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040614003708.GS1444@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox