public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: linux-kernel@vger.kernel.org
Subject: [7/12] Handle NO_SENSE in sd_rw_intr in sd.c
Date: Sun, 13 Jun 2004 17:40:34 -0700	[thread overview]
Message-ID: <20040614004034.GV1444@holomorphy.com> (raw)
In-Reply-To: <20040614003929.GU1444@holomorphy.com>

 * Handle NO_SENSE in sd_rw_intr in drivers/scsi/sd.c (Alan Stern)
This fixes Debian BTS #232494.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=232494

	Message-ID: <402C7AEF.6030206@post.cz>
	From: =?windows-1252?Q?Tonda_M=ED=9Aek?= <tonda.misek@post.cz>
	To: submit@bugs.debian.org
	Subject: mount not work for usb-storage with vfat

I have unstable Debian distribution.
The usb-storage device is USB flash disk.

mount -t vfat /dev/sda1 /ahd/

mount: /dev/sda1: can't read superblock
SCSI error: <1 0 0 0> return code 0x8000000
Current sda: sense key No sense
end_request: I/O error, dev sda, sector 32
FAT: unable to read boot sector

Moreover vfat driver not recognize mount option "isocharset=iso8859-2" 
at all.

With kernel 2.4.24 all works without problems

Index: linux-2.5/drivers/scsi/sd.c
===================================================================
--- linux-2.5.orig/drivers/scsi/sd.c	2004-06-13 11:57:24.000000000 -0700
+++ linux-2.5/drivers/scsi/sd.c	2004-06-13 12:08:56.000000000 -0700
@@ -770,6 +770,14 @@
 			 * hard error.
 			 */
 			print_sense("sd", SCpnt);
+			/* FALLS THROUGH */
+
+		case NO_SENSE:
+			/*
+			 * The low-level driver got the sense data but
+			 * everything was all right.  Don't treat this
+			 * as an error.
+			 */
 			SCpnt->result = 0;
 			SCpnt->sense_buffer[0] = 0x0;
 			good_bytes = this_count;

  reply	other threads:[~2004-06-14  0:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-14  0:31 [0/12] Debian bugfixes William Lee Irwin III
2004-06-14  0:33 ` [1/12] don't dereference netdev->name before register_netdev() William Lee Irwin III
2004-06-14  0:34   ` [2/12] lower priority of "too many keys" msg in atkbd.c William Lee Irwin III
2004-06-14  0:36     ` [3/12] remove irda usage of isa_virt_to_bus() William Lee Irwin III
2004-06-14  0:37       ` [4/12] unregister driver if probing fails in sb_card.c William Lee Irwin III
2004-06-14  0:38         ` [5/12] Ignore errors from tw_setfeature in 3w-xxxx.c William Lee Irwin III
2004-06-14  0:39           ` [6/12] fix advansys.c highmem bugs William Lee Irwin III
2004-06-14  0:40             ` William Lee Irwin III [this message]
2004-06-14  0:41               ` [8/12] fake inquiry for Sony Clie PEG-TJ25 in unusual_devs.h William Lee Irwin III
2004-06-14  0:43                 ` [9/12] fix duplicate environment variables passed to init William Lee Irwin III
2004-06-14  0:45                   ` [10/12] fix handling of '/' embedded in filenames in isofs William Lee Irwin III
2004-06-14  0:47                     ` [11/12] fix isofs ignoring noexec and mode mount options William Lee Irwin III
2004-06-14  0:48                       ` [12/12] fix thread_info.h ignoring __HAVE_THREAD_FUNCTIONS William Lee Irwin III
2004-06-14  8:16                         ` Christoph Hellwig
2004-06-14  8:34                           ` William Lee Irwin III
2004-06-14 10:19                           ` Roman Zippel
2004-06-14 10:23                             ` Christoph Hellwig
2004-06-14 10:47                               ` Roman Zippel
2004-06-14  8:15                     ` [10/12] fix handling of '/' embedded in filenames in isofs Christoph Hellwig
2004-06-14  8:14                 ` [8/12] fake inquiry for Sony Clie PEG-TJ25 in unusual_devs.h Christoph Hellwig
2004-06-14  8:14               ` [7/12] Handle NO_SENSE in sd_rw_intr in sd.c Christoph Hellwig
2004-06-14  4:26             ` [6/12] fix advansys.c highmem bugs Andrew Morton
2004-06-14  8:11               ` William Lee Irwin III
2004-06-14  8:13             ` Christoph Hellwig
2004-06-14  8:12           ` [5/12] Ignore errors from tw_setfeature in 3w-xxxx.c Christoph Hellwig
2004-06-14  8:11       ` [3/12] remove irda usage of isa_virt_to_bus() Christoph Hellwig
2004-06-14  8:11     ` [2/12] lower priority of "too many keys" msg in atkbd.c Christoph Hellwig
2004-06-14  4:14   ` [1/12] don't dereference netdev->name before register_netdev() Andrew Morton
2004-06-14  4:27   ` Jeff Garzik
2004-06-14  5:26     ` Herbert Xu
2004-06-14  8:21       ` William Lee Irwin III
2004-06-14  8:10   ` Christoph Hellwig
2004-06-14  8:22     ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040614004034.GV1444@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox