* [I4L] Fix IRQ-sharing lockup in nj_s
@ 2004-07-27 8:22 Herbert Xu
2004-07-27 10:19 ` Karsten Keil
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2004-07-27 8:22 UTC (permalink / raw)
To: Marcelo Tosatti, kkeil, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
Hi:
This is a backport of a fix that's already in 2.6. The problem is that
nj_s is enabling interrupts before the handler is even installed. This
patch delays the call until after the handler has been registered.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 583 bytes --]
===== drivers/isdn/hisax/nj_s.c 1.7 vs edited =====
--- 1.7/drivers/isdn/hisax/nj_s.c 2002-04-01 11:02:11 +10:00
+++ edited/drivers/isdn/hisax/nj_s.c 2004-07-27 18:19:41 +10:00
@@ -130,6 +130,7 @@
release_io_netjet(cs);
return(0);
case CARD_INIT:
+ reset_netjet_s(cs);
inittiger(cs);
clear_pending_isac_ints(cs);
initisac(cs);
@@ -262,7 +263,6 @@
} else {
request_region(cs->hw.njet.base, bytecnt, "netjet-s isdn");
}
- reset_netjet_s(cs);
cs->readisac = &NETjet_ReadIC;
cs->writeisac = &NETjet_WriteIC;
cs->readisacfifo = &NETjet_ReadICfifo;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [I4L] Fix IRQ-sharing lockup in nj_s
2004-07-27 8:22 [I4L] Fix IRQ-sharing lockup in nj_s Herbert Xu
@ 2004-07-27 10:19 ` Karsten Keil
2004-07-27 21:56 ` Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: Karsten Keil @ 2004-07-27 10:19 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Herbert Xu, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]
Yes, correct.
On Tue, Jul 27, 2004 at 06:22:41PM +1000, Herbert Xu wrote:
> Hi:
>
> This is a backport of a fix that's already in 2.6. The problem is that
> nj_s is enabling interrupts before the handler is even installed. This
> patch delays the call until after the handler has been registered.
>
> Cheers,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Signed-off-by: Karsten Keil <kkeil@suse.de>
===== drivers/isdn/hisax/nj_s.c 1.7 vs edited =====
--- 1.7/drivers/isdn/hisax/nj_s.c 2002-04-01 11:02:11 +10:00
+++ edited/drivers/isdn/hisax/nj_s.c 2004-07-27 18:19:41 +10:00
@@ -130,6 +130,7 @@
release_io_netjet(cs);
return(0);
case CARD_INIT:
+ reset_netjet_s(cs);
inittiger(cs);
clear_pending_isac_ints(cs);
initisac(cs);
@@ -262,7 +263,6 @@
} else {
request_region(cs->hw.njet.base, bytecnt, "netjet-s isdn");
}
- reset_netjet_s(cs);
cs->readisac = &NETjet_ReadIC;
cs->writeisac = &NETjet_WriteIC;
cs->readisacfifo = &NETjet_ReadICfifo;
--
Karsten Keil
SuSE Labs
ISDN development
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [I4L] Fix IRQ-sharing lockup in nj_s
2004-07-27 10:19 ` Karsten Keil
@ 2004-07-27 21:56 ` Marcelo Tosatti
0 siblings, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2004-07-27 21:56 UTC (permalink / raw)
To: Herbert Xu, Linux Kernel Mailing List
Applied, thanks Herbert and Karsten.
Just please stop using my old email address :)
On Tue, Jul 27, 2004 at 12:19:27PM +0200, Karsten Keil wrote:
> Yes, correct.
>
> On Tue, Jul 27, 2004 at 06:22:41PM +1000, Herbert Xu wrote:
> > Hi:
> >
> > This is a backport of a fix that's already in 2.6. The problem is that
> > nj_s is enabling interrupts before the handler is even installed. This
> > patch delays the call until after the handler has been registered.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-07-27 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-27 8:22 [I4L] Fix IRQ-sharing lockup in nj_s Herbert Xu
2004-07-27 10:19 ` Karsten Keil
2004-07-27 21:56 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox