From: Vojtech Pavlik <vojtech@suse.cz>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Andrew Morton <akpm@osdl.org>,
aebr@win.tue.nl, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix NR_KEYS off-by-one error
Date: Tue, 27 Jul 2004 19:54:39 +0200 [thread overview]
Message-ID: <20040727175439.GA1358@ucw.cz> (raw)
In-Reply-To: <878yd5be4z.fsf@devron.myhome.or.jp>
On Wed, Jul 28, 2004 at 01:37:00AM +0900, OGAWA Hirofumi wrote:
> Vojtech Pavlik <vojtech@suse.cz> writes:
>
> > > This all seems a bit inconclusive. Do we proceed with the original patch
> > > or not? If not, how do we fix the overflow which Hirofumi has identified?
> >
> > I think we should check the value in the ioctl, regardless of what's
> > NR_KEYS defined to.
>
> However, it breaks the current binary instead. (at least
> console-tools, kbdutils).
We can do both, then, if that helps.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2004-07-27 17:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-16 16:35 [PATCH] Fix NR_KEYS off-by-one error OGAWA Hirofumi
2004-07-16 16:44 ` Vojtech Pavlik
2004-07-16 17:18 ` OGAWA Hirofumi
2004-07-16 20:15 ` Andries Brouwer
2004-07-17 6:23 ` OGAWA Hirofumi
2004-07-26 22:43 ` Andrew Morton
2004-07-27 13:46 ` Vojtech Pavlik
2004-07-27 16:37 ` OGAWA Hirofumi
2004-07-27 17:54 ` Vojtech Pavlik [this message]
2004-07-27 18:35 ` OGAWA Hirofumi
2004-07-28 11:51 ` Andries Brouwer
2004-07-28 16:46 ` OGAWA Hirofumi
2004-07-28 20:42 ` Paul Jackson
2004-07-29 4:10 ` OGAWA Hirofumi
2004-07-29 6:15 ` Paul Jackson
2004-07-29 9:24 ` OGAWA Hirofumi
2004-07-29 9:49 ` Paul Jackson
2004-07-29 23:24 ` Andrew Morton
2004-07-29 23:51 ` Paul Jackson
2004-07-30 1:25 ` OGAWA Hirofumi
2004-07-30 7:27 ` Paul Jackson
2004-07-30 8:07 ` Vojtech Pavlik
2004-07-30 8:41 ` Andries Brouwer
2004-07-30 8:51 ` Vojtech Pavlik
2004-07-30 9:03 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040727175439.GA1358@ucw.cz \
--to=vojtech@suse.cz \
--cc=aebr@win.tue.nl \
--cc=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox