From: Paul Jackson <pj@sgi.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: aebr@win.tue.nl, vojtech@suse.cz, torvalds@osdl.org,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix NR_KEYS off-by-one error
Date: Thu, 29 Jul 2004 02:49:31 -0700 [thread overview]
Message-ID: <20040729024931.4b4e78e6.pj@sgi.com> (raw)
In-Reply-To: <87oelzjhcx.fsf@ibmpc.myhome.or.jp>
> I didn't see any big cleanup in your patch.
That could well be <grin>. Beauty is in the eye of the beholder.
I figured that replacing the #define's with local variables
was worth a couple of style points, and that explicitly
checking that the user provided values were within limits,
all the time, no ifdefs, was more straight forward.
But it is difficult to establish such preferences with certainty.
Again, thanks for considering my reply.
Do as you think best. I am afraid I have no more wisdom (if
ever I had any ...).
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next prev parent reply other threads:[~2004-07-29 9:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-16 16:35 [PATCH] Fix NR_KEYS off-by-one error OGAWA Hirofumi
2004-07-16 16:44 ` Vojtech Pavlik
2004-07-16 17:18 ` OGAWA Hirofumi
2004-07-16 20:15 ` Andries Brouwer
2004-07-17 6:23 ` OGAWA Hirofumi
2004-07-26 22:43 ` Andrew Morton
2004-07-27 13:46 ` Vojtech Pavlik
2004-07-27 16:37 ` OGAWA Hirofumi
2004-07-27 17:54 ` Vojtech Pavlik
2004-07-27 18:35 ` OGAWA Hirofumi
2004-07-28 11:51 ` Andries Brouwer
2004-07-28 16:46 ` OGAWA Hirofumi
2004-07-28 20:42 ` Paul Jackson
2004-07-29 4:10 ` OGAWA Hirofumi
2004-07-29 6:15 ` Paul Jackson
2004-07-29 9:24 ` OGAWA Hirofumi
2004-07-29 9:49 ` Paul Jackson [this message]
2004-07-29 23:24 ` Andrew Morton
2004-07-29 23:51 ` Paul Jackson
2004-07-30 1:25 ` OGAWA Hirofumi
2004-07-30 7:27 ` Paul Jackson
2004-07-30 8:07 ` Vojtech Pavlik
2004-07-30 8:41 ` Andries Brouwer
2004-07-30 8:51 ` Vojtech Pavlik
2004-07-30 9:03 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040729024931.4b4e78e6.pj@sgi.com \
--to=pj@sgi.com \
--cc=aebr@win.tue.nl \
--cc=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox