public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* cciss update [1/8] ioctl32 fix
@ 2004-08-10 16:01 mikem
  2004-08-10 16:25 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: mikem @ 2004-08-10 16:01 UTC (permalink / raw)
  To: akpm, axboe; +Cc: linux-kernel

My latest updates are not in 2.6.8-rc4. So I am resubmitting them.

Patch 1 of 8
This patch fixes our usage of copy_to_user. We were passing in the size
of the address rather than the size of the struct.
Patch applies to 2.6.8-rc4. Please apply in order.

Thanks,
mikem
-------------------------------------------------------------------------------
diff -burpN lx268-rc3.orig/drivers/block/cciss.c lx268-rc3/drivers/block/cciss.c
--- lx268-rc3.orig/drivers/block/cciss.c	2004-08-05 09:55:58.023683000 -0500
+++ lx268-rc3/drivers/block/cciss.c	2004-08-05 10:22:43.290646176 -0500
@@ -578,7 +578,7 @@ int cciss_ioctl32_passthru(unsigned int 
 	err = sys_ioctl(fd, CCISS_PASSTHRU, (unsigned long) p);
 	if (err)
 		return err;
-	err |= copy_in_user(&arg32->error_info, &p->error_info, sizeof(&arg32->error_info));
+	err |= copy_in_user(&arg32->error_info, &p->error_info, sizeof(arg32->error_info));
 	if (err)
 		return -EFAULT;
 	return err;
@@ -610,7 +610,7 @@ int cciss_ioctl32_big_passthru(unsigned 
 	err = sys_ioctl(fd, CCISS_BIG_PASSTHRU, (unsigned long) p);
 	if (err)
 		return err;
-	err |= copy_in_user(&arg32->error_info, &p->error_info, sizeof(&arg32->error_info));
+	err |= copy_in_user(&arg32->error_info, &p->error_info, sizeof(arg32->error_info));
 	if (err)
 		return -EFAULT;
 	return err;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: cciss update [1/8] ioctl32 fix
  2004-08-10 16:01 cciss update [1/8] ioctl32 fix mikem
@ 2004-08-10 16:25 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2004-08-10 16:25 UTC (permalink / raw)
  To: mikem; +Cc: akpm, linux-kernel

On Tue, Aug 10 2004, mikem wrote:
> My latest updates are not in 2.6.8-rc4. So I am resubmitting them.

They are in -mm, it's customary for patches for misc drivers to go
through there and be fed to Linus by Andrew after a little while. So if
they are in -mm, you can consider them safely on their way to Linus.
I've never seen Andrew drop patches from -mm without first asking.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-08-10 16:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-10 16:01 cciss update [1/8] ioctl32 fix mikem
2004-08-10 16:25 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox