From: Roland McGrath <roland@redhat.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] notify_parent cleanup
Date: Thu, 19 Aug 2004 15:04:36 -0700 [thread overview]
Message-ID: <200408192204.i7JM4aP7025390@magilla.sf.frob.com> (raw)
In-Reply-To: OGAWA Hirofumi's message of Friday, 20 August 2004 07:01:58 +0900 <87y8kazt0p.fsf@devron.myhome.or.jp>
> Roland McGrath <roland@redhat.com> writes:
>
> > > Roland McGrath <roland@redhat.com> writes:
> > > > + BUG_ON(tsk->state != TASK_STOPPED);
> > >
> > > task->state is changed anytime, right? Although the window is small,
> > > I think we should remove it at least for right now.
>
> > I put it there intending just to ensure that all the code paths
> > were the stopping ones, as all the extant ones are.
>
> Ah, I see.
>
> Instead of BUG_ON(), how about WARN_ON() for debug? Since window is
> small...
It's small but certainly valid. I think it's better to leave the assertion
out entirely for the moment, and just revamp this so that notify_parent as
such no longer exists.
Thanks,
Roland
prev parent reply other threads:[~2004-08-19 22:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-18 0:40 [PATCH] notify_parent cleanup Roland McGrath
2004-08-18 6:44 ` Andrew Morton
2004-08-21 1:09 ` [PATCH] notify_parent and ptrace cleanup Roland McGrath
2004-08-21 11:47 ` OGAWA Hirofumi
2004-08-25 2:43 ` Roland McGrath
2004-08-25 17:51 ` OGAWA Hirofumi
2004-08-25 18:08 ` Roland McGrath
2004-08-25 19:48 ` OGAWA Hirofumi
2004-08-25 19:54 ` Linus Torvalds
2004-08-25 20:20 ` Roland McGrath
2004-08-25 20:53 ` OGAWA Hirofumi
2004-08-25 21:02 ` Linus Torvalds
2004-08-25 21:07 ` Roland McGrath
2004-08-25 21:45 ` OGAWA Hirofumi
2004-08-19 4:26 ` [PATCH] notify_parent cleanup OGAWA Hirofumi
2004-08-19 20:59 ` Roland McGrath
2004-08-19 22:01 ` OGAWA Hirofumi
2004-08-19 22:04 ` Roland McGrath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408192204.i7JM4aP7025390@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).