From: Russell King <rmk+lkml@arm.linux.org.uk>
To: "Kilau, Scott" <Scott_Kilau@digi.com>
Cc: linux-kernel@vger.kernel.org, wenxiong@us.ibm.com
Subject: Re: [PATCH 2.6.8.1] drivers/char: New serial driver.
Date: Mon, 27 Sep 2004 21:31:12 +0100 [thread overview]
Message-ID: <20040927213112.B26680@flint.arm.linux.org.uk> (raw)
In-Reply-To: <71A17D6448EC0140B44BCEB8CD0DA36E04B9D774@minimail.digi.com>; from Scott_Kilau@digi.com on Mon, Sep 27, 2004 at 03:03:32PM -0500
On Mon, Sep 27, 2004 at 03:03:32PM -0500, Kilau, Scott wrote:
> I am submitting a new serial driver for the 2.6 series of kernels.
>
> Description:
> Digi serial driver for the Digi Neo and Classic PCI serial port
> products.
>
> IBM has requested this submission into the Linux kernel.
>
> The patch is quite large (300K uncompressed), so rather than attach it
> I am submitting a link to our ftp site where the patch is located.
>
> ftp://ftp1.digi.com/pub/patches/dgnc.patch
A few comments:
(1) I'm disappointed that you aren't using the serial_core support
in drivers/serial.
(2) I'm also concerned that you're using serial_reg.h as a description
of an interface between your hardware specific drivers and your
hardware independent tty core. It isn't a description of such an
interface and therefore should not be used as such. Please fix
your code in respect to this.
(3) loopback mode is normally enabled by setting TIOCM_LOOP modem
control bit via the TIOCMBIS ioctl.
I'd also like Alan Cox to look over the driver since he's looking at
the tty layer. Alan may have further comments since I've only briefly
looked through it.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-09-27 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 20:03 [PATCH 2.6.8.1] drivers/char: New serial driver Kilau, Scott
2004-09-27 20:31 ` Russell King [this message]
2004-09-28 20:16 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2004-09-28 20:09 Kilau, Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040927213112.B26680@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=Scott_Kilau@digi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox