From: Andrew Morton <akpm@osdl.org>
To: Werner Almesberger <werner@almesberger.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] boot parameters: quoting of environment variables revisited
Date: Tue, 19 Oct 2004 18:04:40 -0700 [thread overview]
Message-ID: <20041019180440.1ff780c5.akpm@osdl.org> (raw)
In-Reply-To: <20041019192336.K18873@almesberger.net>
Werner Almesberger <werner@almesberger.net> wrote:
>
> When passing boot parameters, they can be quoted as follows:
> param="value"
>
> Unfortunately, when passing environment variables this way, the
> quoting causes confusion: in 2.6.7 (etc.), only the variable name
> was placed in the environment, which caused it to be ignored.
Bummer.
> I've sent a patch that adjusted the name, but this patch was
> dropped. Instead, apparently a different fix was attempted in
> 2.6.9, but this now yields param="value in the environment (note
> the embeded double quote), which isn't much better.
Yes, Len's patch purported to fix the same thing. I should have got you to
review&test that change. Didn't think of it, sorry.
> I've attached a patch for 2.6.9 that fixes this. This time, I'm
> shifting the value. Maybe you like it better this way :-)
hm. The environment string handling and the "command line" string handling
appear to be identical in there. How come only one of them has the
problem? That function makes my eyes bleed.
next prev parent reply other threads:[~2004-10-20 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 22:23 [PATCH] boot parameters: quoting of environment variables revisited Werner Almesberger
2004-10-20 1:04 ` Andrew Morton [this message]
2004-10-20 1:47 ` Werner Almesberger
2004-10-20 6:21 ` Rusty Russell
2004-10-20 7:16 ` [PATCH] boot parameters: quoting of environment variablesrevisited Len Brown
2004-10-20 7:35 ` Rusty Russell
2004-10-20 7:53 ` [PATCH] boot parameters: quoting of environmentvariablesrevisited Len Brown
2004-10-20 8:03 ` Rusty Russell
2004-10-22 1:01 ` Rusty Russell
2004-10-20 9:04 ` [PATCH] boot parameters: quoting of environment variablesrevisited Werner Almesberger
2004-10-20 9:27 ` [PATCH] boot parameters: quoting of environment variables revisited Werner Almesberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041019180440.1ff780c5.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=werner@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox