From: Werner Almesberger <werner@almesberger.net>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] boot parameters: quoting of environment variables revisited
Date: Tue, 19 Oct 2004 22:47:32 -0300 [thread overview]
Message-ID: <20041019224732.P18873@almesberger.net> (raw)
In-Reply-To: <20041019180440.1ff780c5.akpm@osdl.org>; from akpm@osdl.org on Tue, Oct 19, 2004 at 06:04:40PM -0700
Andrew Morton wrote:
> hm. The environment string handling and the "command line" string handling
> appear to be identical in there. How come only one of them has the
> problem? That function makes my eyes bleed.
The joy of "clever" string manipulation, I suppose :-(
The difference between the two branches is that the "command line"
thing uses only the parameter name, which cannot be quoted (well,
at least kernel/params.c doesn't let this happen). So the whole
problem can't occur.
If you quote the parameter name, the quotes will happily end up
in the argument, thanks to kernel/params.c.
Perhaps a better long-term solution would be to fix all this in
kernel/params.c, and remove any quote special-casing from
init/main.c. It just scares me to touch such a highly sensitive
area of the kernel ... :)
- Werner
--
_________________________________________________________________________
/ Werner Almesberger, Buenos Aires, Argentina werner@almesberger.net /
/_http://www.almesberger.net/____________________________________________/
next prev parent reply other threads:[~2004-10-20 1:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 22:23 [PATCH] boot parameters: quoting of environment variables revisited Werner Almesberger
2004-10-20 1:04 ` Andrew Morton
2004-10-20 1:47 ` Werner Almesberger [this message]
2004-10-20 6:21 ` Rusty Russell
2004-10-20 7:16 ` [PATCH] boot parameters: quoting of environment variablesrevisited Len Brown
2004-10-20 7:35 ` Rusty Russell
2004-10-20 7:53 ` [PATCH] boot parameters: quoting of environmentvariablesrevisited Len Brown
2004-10-20 8:03 ` Rusty Russell
2004-10-22 1:01 ` Rusty Russell
2004-10-20 9:04 ` [PATCH] boot parameters: quoting of environment variablesrevisited Werner Almesberger
2004-10-20 9:27 ` [PATCH] boot parameters: quoting of environment variables revisited Werner Almesberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041019224732.P18873@almesberger.net \
--to=werner@almesberger.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox