* [RFT 2.6] intel-mch-agp.c: replace pci_find_device with pci_get_device
@ 2004-10-20 18:53 Hanna Linder
2004-10-20 22:04 ` [KJ] " Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Hanna Linder @ 2004-10-20 18:53 UTC (permalink / raw)
To: lkml, kernel-janitors; +Cc: Hanna Linder, greg, davej
As pci_find_device is going away soon I have converted this file to use
pci_get_device instead. I have compile tested it. If anyone has this hardware
and could test it that would be great.
Hanna Linder
IBM Linux Technology Center
Signed-off-by: Hanna Linder <hannal@us.ibm.com>
---
diff -Nrup linux-2.6.9cln/drivers/char/agp/intel-mch-agp.c linux-2.6.9patch3/drivers/char/agp/intel-mch-agp.c
--- linux-2.6.9cln/drivers/char/agp/intel-mch-agp.c 2004-10-18 16:35:52.000000000 -0700
+++ linux-2.6.9patch3/drivers/char/agp/intel-mch-agp.c 2004-10-18 17:23:22.000000000 -0700
@@ -470,9 +470,9 @@ static int find_i830(u16 device)
{
struct pci_dev *i830_dev;
- i830_dev = pci_find_device(PCI_VENDOR_ID_INTEL, device, NULL);
+ i830_dev = pci_get_device(PCI_VENDOR_ID_INTEL, device, NULL);
if (i830_dev && PCI_FUNC(i830_dev->devfn) != 0) {
- i830_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
+ i830_dev = pci_get_device(PCI_VENDOR_ID_INTEL,
device, i830_dev);
}
@@ -565,6 +565,7 @@ static void __devexit agp_intelmch_remov
{
struct agp_bridge_data *bridge = pci_get_drvdata(pdev);
+ pci_dev_put(pdev);
agp_remove_bridge(bridge);
agp_put_bridge(bridge);
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [KJ] [RFT 2.6] intel-mch-agp.c: replace pci_find_device with pci_get_device
2004-10-20 18:53 [RFT 2.6] intel-mch-agp.c: replace pci_find_device with pci_get_device Hanna Linder
@ 2004-10-20 22:04 ` Matthew Wilcox
2004-10-20 22:06 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2004-10-20 22:04 UTC (permalink / raw)
To: Hanna Linder; +Cc: lkml, kernel-janitors, greg, davej
On Wed, Oct 20, 2004 at 11:53:01AM -0700, Hanna Linder wrote:
>
> As pci_find_device is going away soon I have converted this file to use
> pci_get_device instead. I have compile tested it. If anyone has this hardware
> and could test it that would be great.
Also a pci_driver candidate.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ] [RFT 2.6] intel-mch-agp.c: replace pci_find_device with pci_get_device
2004-10-20 22:04 ` [KJ] " Matthew Wilcox
@ 2004-10-20 22:06 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2004-10-20 22:06 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: Hanna Linder, davej, kernel-janitors, lkml, greg
On Wed, Oct 20, 2004 at 11:04:13PM +0100, Matthew Wilcox wrote:
> On Wed, Oct 20, 2004 at 11:53:01AM -0700, Hanna Linder wrote:
> >
> > As pci_find_device is going away soon I have converted this file to use
> > pci_get_device instead. I have compile tested it. If anyone has this hardware
> > and could test it that would be great.
>
> Also a pci_driver candidate.
Same issue as above
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-10-20 22:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-20 18:53 [RFT 2.6] intel-mch-agp.c: replace pci_find_device with pci_get_device Hanna Linder
2004-10-20 22:04 ` [KJ] " Matthew Wilcox
2004-10-20 22:06 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox