* [PATCH] make buffer head argument of buffer_##name "const"
@ 2004-10-26 6:32 Werner Almesberger
2004-10-26 7:23 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Werner Almesberger @ 2004-10-26 6:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton
This one is embarrassingly simple. Unfortunately, it doesn't meet
the requirements for the patch monkey, so here goes a "regular"
submission.
I've checked that the argument of test_bit is indeed "const" on
all architectures. The patch is for 2.6.9.
- Werner
---------------------------------- cut here -----------------------------------
Signed-off-by: Werner Almesberger <werner@almesberger.net>
--- linux-2.6.9/include/linux/buffer_head.h.orig Tue Oct 26 02:57:54 2004
+++ linux-2.6.9/include/linux/buffer_head.h Tue Oct 26 02:21:04 2004
@@ -76,7 +76,7 @@
{ \
clear_bit(BH_##bit, &(bh)->b_state); \
} \
-static inline int buffer_##name(struct buffer_head *bh) \
+static inline int buffer_##name(const struct buffer_head *bh) \
{ \
return test_bit(BH_##bit, &(bh)->b_state); \
}
--
_________________________________________________________________________
/ Werner Almesberger, Buenos Aires, Argentina werner@almesberger.net /
/_http://www.almesberger.net/____________________________________________/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] make buffer head argument of buffer_##name "const"
2004-10-26 6:32 [PATCH] make buffer head argument of buffer_##name "const" Werner Almesberger
@ 2004-10-26 7:23 ` Andrew Morton
2004-10-26 7:38 ` Werner Almesberger
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2004-10-26 7:23 UTC (permalink / raw)
To: Werner Almesberger; +Cc: linux-kernel
Werner Almesberger <werner@almesberger.net> wrote:
>
> --- linux-2.6.9/include/linux/buffer_head.h.orig Tue Oct 26 02:57:54 2004
> +++ linux-2.6.9/include/linux/buffer_head.h Tue Oct 26 02:21:04 2004
> @@ -76,7 +76,7 @@
> { \
> clear_bit(BH_##bit, &(bh)->b_state); \
> } \
> -static inline int buffer_##name(struct buffer_head *bh) \
> +static inline int buffer_##name(const struct buffer_head *bh) \
> { \
> return test_bit(BH_##bit, &(bh)->b_state); \
> }
OK, but why? Does it generate better code or something?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] make buffer head argument of buffer_##name "const"
2004-10-26 7:23 ` Andrew Morton
@ 2004-10-26 7:38 ` Werner Almesberger
0 siblings, 0 replies; 3+ messages in thread
From: Werner Almesberger @ 2004-10-26 7:38 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Andrew Morton wrote:
> OK, but why? Does it generate better code or something?
I wouldn't expect this to change the resulting code. It's just
so that one can feed it a "const" pointer, which allows other
functions to use "const", etc.
- Werner
--
_________________________________________________________________________
/ Werner Almesberger, Buenos Aires, Argentina werner@almesberger.net /
/_http://www.almesberger.net/____________________________________________/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-10-26 7:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-26 6:32 [PATCH] make buffer head argument of buffer_##name "const" Werner Almesberger
2004-10-26 7:23 ` Andrew Morton
2004-10-26 7:38 ` Werner Almesberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox