From: Pavel Machek <pavel@ucw.cz>
To: "Zhu, Yi" <yi.zhu@intel.com>
Cc: Andrew Morton <akpm@osdl.org>, Shaohua Li <shaohua.li@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [swsusp] print error message when swapping is disabled
Date: Fri, 29 Oct 2004 11:10:12 +0200 [thread overview]
Message-ID: <20041029091012.GA1003@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44.0410291500250.29394-100000@mazda.sh.intel.com>
Hi!
> > Another case is PSE disabled. Should notify this to user also.
>
> Here is a patch to address it.
Patch is okay (but I rararely see this kind of failure in
wild). Please submit via akpm.
Anyway, the most common problem these days is that one of devices
vetoes the suspend. In such case code does the right thing, but
without any message to the user... and that is kind of confusing.
Patch printing "swsusp failed because device XXXX vetoed it" would be
very welcome.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-10-29 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 10:16 [PATCH] [swsusp] print error message when swapping is disabled Li, Shaohua
2004-10-29 7:07 ` Zhu, Yi
2004-10-29 9:10 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-29 9:54 Li, Shaohua
2004-10-29 9:59 ` Pavel Machek
2004-10-29 19:30 ` Nigel Cunningham
2004-10-25 2:56 Zhu, Yi
2004-10-25 10:27 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041029091012.GA1003@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox