public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Li, Shaohua" <shaohua.li@intel.com>
Cc: "Zhu, Yi" <yi.zhu@intel.com>, Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [swsusp] print error message when swapping is disabled
Date: Fri, 29 Oct 2004 11:59:52 +0200	[thread overview]
Message-ID: <20041029095952.GB1003@elf.ucw.cz> (raw)
In-Reply-To: <16A54BF5D6E14E4D916CE26C9AD305756F342F@pdsmsx402.ccr.corp.intel.com>

Hi!

> >> > Another case is PSE disabled. Should notify this to user also.
> >>
> >> Here is a patch to address it.
> >
> >Patch is okay (but I rararely see this kind of failure in
> >wild). Please submit via akpm.
> >
> Enable DEBUG_PAGEALLOC will disable PSE. 
> Possibly a stupid question, why swsusp need PSE? I didn't see any
> relationship between the two.

swsusp relies on fact that kernel 1:1 mapping is self-contained in
top-level pagedir. That is not true without PSE, right?

[Hmm, probably bigger comment explaining this would be nice...]

								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

  reply	other threads:[~2004-10-29 10:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-29  9:54 [PATCH] [swsusp] print error message when swapping is disabled Li, Shaohua
2004-10-29  9:59 ` Pavel Machek [this message]
2004-10-29 19:30 ` Nigel Cunningham
  -- strict thread matches above, loose matches on Subject: below --
2004-10-26 10:16 Li, Shaohua
2004-10-29  7:07 ` Zhu, Yi
2004-10-29  9:10   ` Pavel Machek
2004-10-25  2:56 Zhu, Yi
2004-10-25 10:27 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041029095952.GB1003@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox