From: Ingo Molnar <mingo@elte.hu>
To: "Måns Rullgård" <mru@inprovide.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SysRq-n changes RT tasks to normal
Date: Fri, 29 Oct 2004 13:34:05 +0200 [thread overview]
Message-ID: <20041029113405.GA32204@elte.hu> (raw)
In-Reply-To: <yw1xy8hpix4z.fsf@inprovide.com>
* Måns Rullgård <mru@inprovide.com> wrote:
> + for_each_process (p) {
> + if (!rt_task(p))
> + continue;
> +
> + read_lock_irq(&tasklist_lock);
> + rq = task_rq_lock(p, &flags);
you must take the tasklist_lock outside the for_each_process().
otherwise, looks good.
Ingo
next prev parent reply other threads:[~2004-10-29 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 11:25 [PATCH] SysRq-n changes RT tasks to normal Måns Rullgård
2004-10-29 11:34 ` Ingo Molnar [this message]
2004-10-29 11:51 ` Måns Rullgård
2004-10-29 12:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041029113405.GA32204@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mru@inprovide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox