* [2.6 patch] x86_64 hardirq.h: no need to #ifdef CONFIG_X86
@ 2004-11-24 0:19 Adrian Bunk
2004-11-24 10:40 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2004-11-24 0:19 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Christoph Hellwig, ak, discuss, linux-kernel
I can't see any reason for the #ifdef CONFIG_X86 introduced to the
x86_64 hardirq.h as part of the generic irq subsystem changes.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm3-full/include/asm-x86_64/hardirq.h.old 2004-11-23 23:18:20.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/include/asm-x86_64/hardirq.h 2004-11-23 23:18:35.000000000 +0100
@@ -21,7 +21,6 @@
*/
static inline void ack_bad_irq(unsigned int irq)
{
-#ifdef CONFIG_X86
printk("unexpected IRQ trap at vector %02x\n", irq);
#ifdef CONFIG_X86_LOCAL_APIC
/*
@@ -34,6 +33,5 @@
*/
ack_APIC_irq();
#endif
-#endif
}
#endif /* __ASM_HARDIRQ_H */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] x86_64 hardirq.h: no need to #ifdef CONFIG_X86
2004-11-24 0:19 [2.6 patch] x86_64 hardirq.h: no need to #ifdef CONFIG_X86 Adrian Bunk
@ 2004-11-24 10:40 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2004-11-24 10:40 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Ingo Molnar, Christoph Hellwig, ak, discuss, linux-kernel
On Wed, Nov 24, 2004 at 01:19:42AM +0100, Adrian Bunk wrote:
>
> I can't see any reason for the #ifdef CONFIG_X86 introduced to the
> x86_64 hardirq.h as part of the generic irq subsystem changes.
Looks good thanks. I added it to my patchkit.
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-24 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-24 0:19 [2.6 patch] x86_64 hardirq.h: no need to #ifdef CONFIG_X86 Adrian Bunk
2004-11-24 10:40 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox