From: Matt Mackall <mpm@selenic.com>
To: Colin Leroy <colin@colino.net>
Cc: linux-kernel@vger.kernel.org, hirofumi@mail.parknet.co.jp
Subject: Re: [PATCH] let fat handle MS_SYNCHRONOUS flag
Date: Tue, 23 Nov 2004 19:17:26 -0800 [thread overview]
Message-ID: <20041124031726.GF8040@waste.org> (raw)
In-Reply-To: <20041118194959.3f1a3c8e.colin@colino.net>
On Thu, Nov 18, 2004 at 07:49:59PM +0100, Colin Leroy wrote:
> Hi,
>
> this patch is an RFC patch not to be applied.
> It adds MS_SYNCHRONOUS support to FAT filesystem, so that less
> filesystem breakage happen when disconnecting an USB key, for
> example. I'd like to have comments about it, because as it
> seems to work fine here, I'm not used to fs drivers and could
> have made mistakes.
> Thanks,
>
> + if (bh != NULL) {
> + sync_dirty_buffer(bh);
> + brelse(bh);
> + } else {
> + BUG_ON(1);
This construct is really weird.
How about:
BUG_ON(!bh);
sync_dirty_buffer(bh);
brelse(bh);
Concept seems good, and the implementation otherwise looks good at
first glance.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2004-11-24 3:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-18 18:49 [PATCH] let fat handle MS_SYNCHRONOUS flag Colin Leroy
2004-11-18 18:51 ` [PATCH] let vfat " Colin Leroy
2004-11-23 19:32 ` [PATCH] let fat " Colin Leroy
2004-11-23 20:24 ` OGAWA Hirofumi
2004-11-24 3:20 ` Matt Mackall
2004-11-24 5:00 ` OGAWA Hirofumi
2004-11-24 5:35 ` Matt Mackall
2004-11-24 6:26 ` OGAWA Hirofumi
2004-11-24 6:40 ` Andrew Morton
2004-11-24 6:49 ` Matt Mackall
2004-11-24 6:57 ` Andrew Morton
2004-11-24 13:26 ` OGAWA Hirofumi
2004-11-24 5:41 ` Bernd Eckenfels
2004-11-24 7:30 ` Colin Leroy
2004-11-24 3:17 ` Matt Mackall [this message]
2004-11-24 7:34 ` Colin Leroy
2004-11-24 7:50 ` Matt Mackall
2004-11-24 8:40 ` Colin Leroy
2004-11-24 14:02 ` OGAWA Hirofumi
2004-11-24 14:25 ` Colin Leroy
2004-11-24 15:02 ` Colin Leroy
2004-11-24 18:10 ` OGAWA Hirofumi
2004-11-24 20:28 ` Colin Leroy
[not found] ` <87k6saunwl.fsf@devron.myhome.or.jp>
2004-11-25 12:47 ` Colin Leroy
[not found] ` <87act6ulc5.fsf@devron.myhome.or.jp>
2004-11-25 13:11 ` Colin Leroy
2004-12-29 19:33 ` Robert Hardy
2004-12-30 3:02 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041124031726.GF8040@waste.org \
--to=mpm@selenic.com \
--cc=colin@colino.net \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox