public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Colin Leroy <colin@colino.net>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel@vger.kernel.org, hirofumi@mail.parknet.co.jp
Subject: Re: [PATCH] let fat handle MS_SYNCHRONOUS flag
Date: Wed, 24 Nov 2004 08:34:30 +0100	[thread overview]
Message-ID: <20041124083430.5cf5d621@pirandello> (raw)
In-Reply-To: <20041124031726.GF8040@waste.org>

On 23 Nov 2004 at 19h11, Matt Mackall wrote:

Hi, 

> BUG_ON(!bh);
> sync_dirty_buffer(bh);
> brelse(bh);

I wasn't sure sync_dirty_buffer and brelse checked for nullity :)

> Concept seems good, and the implementation otherwise looks good at
> first glance.

Cool :) Should I submit an updated patch to Andrew for -mm ?

Thanks for all the comments. I agree with what most people said, sync
mode is not a guarantee that everything will be fine, but it helps in
most cases.

As for the speed, from what I checked it slows down IO a bit, of course,
but that is within tolerable bounds imho. 
-- 
Colin

  reply	other threads:[~2004-11-24  7:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-18 18:49 [PATCH] let fat handle MS_SYNCHRONOUS flag Colin Leroy
2004-11-18 18:51 ` [PATCH] let vfat " Colin Leroy
2004-11-23 19:32 ` [PATCH] let fat " Colin Leroy
2004-11-23 20:24 ` OGAWA Hirofumi
2004-11-24  3:20   ` Matt Mackall
2004-11-24  5:00     ` OGAWA Hirofumi
2004-11-24  5:35       ` Matt Mackall
2004-11-24  6:26         ` OGAWA Hirofumi
2004-11-24  6:40           ` Andrew Morton
2004-11-24  6:49             ` Matt Mackall
2004-11-24  6:57               ` Andrew Morton
2004-11-24 13:26             ` OGAWA Hirofumi
2004-11-24  5:41       ` Bernd Eckenfels
2004-11-24  7:30         ` Colin Leroy
2004-11-24  3:17 ` Matt Mackall
2004-11-24  7:34   ` Colin Leroy [this message]
2004-11-24  7:50     ` Matt Mackall
2004-11-24  8:40       ` Colin Leroy
2004-11-24 14:02 ` OGAWA Hirofumi
2004-11-24 14:25   ` Colin Leroy
2004-11-24 15:02   ` Colin Leroy
2004-11-24 18:10     ` OGAWA Hirofumi
2004-11-24 20:28       ` Colin Leroy
     [not found]         ` <87k6saunwl.fsf@devron.myhome.or.jp>
2004-11-25 12:47           ` Colin Leroy
     [not found]             ` <87act6ulc5.fsf@devron.myhome.or.jp>
2004-11-25 13:11               ` Colin Leroy
2004-12-29 19:33                 ` Robert Hardy
2004-12-30  3:02                   ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041124083430.5cf5d621@pirandello \
    --to=colin@colino.net \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox