* [2.6 patch] select for drivers/mtd
@ 2003-09-28 15:38 Adrian Bunk
2003-09-28 16:00 ` Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2003-09-28 15:38 UTC (permalink / raw)
To: David Woodhouse, Linus Torvalds; +Cc: linux-kernel
The patch below switches fs/Kconfig to use select where appropriate.
One of the dependencies of MTD_GEN_PROBE was on MTD_INTELPROBE that
isn't in Linus' tree. If this symbol is present in the mtd cvs, a
similar select is needed there.
diffstat output:
drivers/mtd/chips/Kconfig | 4 ++--
drivers/mtd/devices/Kconfig | 10 ++++++----
drivers/mtd/nand/Kconfig | 3 +--
3 files changed, 9 insertions(+), 8 deletions(-)
cu
Adrian
--- linux-2.6.0-test6-full/drivers/mtd/devices/Kconfig.old 2003-09-28 17:20:06.000000000 +0200
+++ linux-2.6.0-test6-full/drivers/mtd/devices/Kconfig 2003-09-28 17:26:15.000000000 +0200
@@ -117,6 +117,8 @@
config MTD_DOC2000
tristate "M-Systems Disk-On-Chip 2000 and Millennium"
depends on MTD
+ select MTD_DOCPROBE
+ select MTD_NAND_IDS
---help---
This provides an MTD device driver for the M-Systems DiskOnChip
2000 and Millennium devices. Originally designed for the DiskOnChip
@@ -134,6 +136,8 @@
config MTD_DOC2001
tristate "M-Systems Disk-On-Chip Millennium-only alternative driver (see help)"
depends on MTD
+ select MTD_DOCPROBE
+ select MTD_NAND_IDS
---help---
This provides an alternative MTD device driver for the M-Systems
DiskOnChip Millennium devices. Use this if you have problems with
@@ -150,6 +154,8 @@
config MTD_DOC2001PLUS
tristate "M-Systems Disk-On-Chip Millennium Plus"
depends on MTD
+ select MTD_DOCPROBE
+ select MTD_NAND_IDS
---help---
This provides an MTD device driver for the M-Systems DiskOnChip
Millennium Plus devices.
@@ -161,10 +167,6 @@
config MTD_DOCPROBE
tristate
- default m if MTD_DOC2001!=y && MTD_DOC2000!=y && MTD_DOC2001PLUS!=y && (MTD_DOC2001=m || MTD_DOC2000=m || MOD_DOC2001PLUS=m)
- default y if MTD_DOC2001=y || MTD_DOC2000=y || MTD_DOC2001PLUS=y
- help
- This isn't a real config option, it's derived.
config MTD_DOCPROBE_ADVANCED
bool "Advanced detection options for DiskOnChip"
--- linux-2.6.0-test6-full/drivers/mtd/nand/Kconfig.old 2003-09-28 17:24:56.000000000 +0200
+++ linux-2.6.0-test6-full/drivers/mtd/nand/Kconfig 2003-09-28 17:26:57.000000000 +0200
@@ -7,6 +7,7 @@
config MTD_NAND
tristate "NAND Device Support"
depends on MTD
+ select MTD_NAND_IDS
help
This enables support for accessing all type of NAND flash
devices with an 8-bit data bus interface. For further
@@ -44,8 +45,6 @@
config MTD_NAND_IDS
tristate
- default y if MTD_NAND = y || MTD_DOC2000 = y || MTD_DOC2001 = y || MTD_DOC2001PLUS = y
- default m if MTD_NAND = m || MTD_DOC2000 = m || MTD_DOC2001 = m || MTD_DOC2001PLUS = m
endmenu
--- linux-2.6.0-test6-full/drivers/mtd/chips/Kconfig.old 2003-09-28 17:27:26.000000000 +0200
+++ linux-2.6.0-test6-full/drivers/mtd/chips/Kconfig 2003-09-28 17:33:42.000000000 +0200
@@ -7,6 +7,7 @@
config MTD_CFI
tristate "Detect flash chips by Common Flash Interface (CFI) probe"
depends on MTD
+ select MTD_GEN_PROBE
help
The Common Flash Interface specification was developed by Intel,
AMD and other flash manufactures that provides a universal method
@@ -18,6 +19,7 @@
config MTD_JEDECPROBE
tristate "Detect non-CFI AMD/JEDEC-compatible flash chips"
depends on MTD
+ select MTD_GEN_PROBE
help
This option enables JEDEC-style probing of flash chips which are not
compatible with the Common Flash Interface, but will use the common
@@ -29,8 +31,6 @@
config MTD_GEN_PROBE
tristate
- default m if MTD_CFI!=y && !MTD_INTELPROBE && MTD_JEDECPROBE!=y && (MTD_CFI=m || MTD_JEDECPROBE=m)
- default y if MTD_CFI=y || MTD_INTELPROBE || MTD_JEDECPROBE=y
config MTD_CFI_ADV_OPTIONS
bool "Flash chip driver advanced configuration options"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] select for drivers/mtd
2003-09-28 15:38 Adrian Bunk
@ 2003-09-28 16:00 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2003-09-28 16:00 UTC (permalink / raw)
To: David Woodhouse, Linus Torvalds; +Cc: linux-kernel
On Sun, Sep 28, 2003 at 05:38:17PM +0200, Adrian Bunk wrote:
> The patch below switches fs/Kconfig to use select where appropriate.
>...
s|fs/Kconfig|drivers/mtd|
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] select for drivers/mtd
@ 2004-11-28 22:56 Adrian Bunk
2004-11-29 23:04 ` David Woodhouse
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2004-11-28 22:56 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-mtd, linux-kernel
The patch below switches options to use select where appropriate.
One of the dependencies of MTD_GEN_PROBE was on MTD_INTELPROBE that
isn't in Linus' tree. If this symbol is present in the mtd cvs, a
similar select is needed there.
What's the purpose of the MTD_DOCECC option, which has always the same
value as the MTD_DOCPROBE option?
diffstat output:
drivers/mtd/chips/Kconfig | 9 +++++----
drivers/mtd/devices/Kconfig | 15 +++++++--------
drivers/mtd/nand/Kconfig | 3 +--
3 files changed, 13 insertions(+), 14 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm3-full/drivers/mtd/chips/Kconfig.old 2004-11-28 23:43:52.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/mtd/chips/Kconfig 2004-11-28 23:46:59.000000000 +0100
@@ -7,6 +7,7 @@
config MTD_CFI
tristate "Detect flash chips by Common Flash Interface (CFI) probe"
depends on MTD
+ select MTD_GEN_PROBE
help
The Common Flash Interface specification was developed by Intel,
AMD and other flash manufactures that provides a universal method
@@ -18,6 +19,7 @@
config MTD_JEDECPROBE
tristate "Detect non-CFI AMD/JEDEC-compatible flash chips"
depends on MTD
+ select MTD_GEN_PROBE
help
This option enables JEDEC-style probing of flash chips which are not
compatible with the Common Flash Interface, but will use the common
@@ -29,8 +31,6 @@
config MTD_GEN_PROBE
tristate
- default m if MTD_CFI!=y && !MTD_INTELPROBE && MTD_JEDECPROBE!=y && (MTD_CFI=m || MTD_JEDECPROBE=m)
- default y if MTD_CFI=y || MTD_INTELPROBE || MTD_JEDECPROBE=y
config MTD_CFI_ADV_OPTIONS
bool "Flash chip driver advanced configuration options"
@@ -158,6 +158,7 @@
config MTD_CFI_INTELEXT
tristate "Support for Intel/Sharp flash chips"
depends on MTD_GEN_PROBE
+ select MTD_CFI_UTIL
help
The Common Flash Interface defines a number of different command
sets which a CFI-compliant chip may claim to implement. This code
@@ -167,6 +168,7 @@
config MTD_CFI_AMDSTD
tristate "Support for AMD/Fujitsu flash chips"
depends on MTD_GEN_PROBE
+ select MTD_CFI_UTIL
help
The Common Flash Interface defines a number of different command
sets which a CFI-compliant chip may claim to implement. This code
@@ -197,6 +199,7 @@
config MTD_CFI_STAA
tristate "Support for ST (Advanced Architecture) flash chips"
depends on MTD_GEN_PROBE
+ select MTD_CFI_UTIL
help
The Common Flash Interface defines a number of different command
sets which a CFI-compliant chip may claim to implement. This code
@@ -204,8 +207,6 @@
config MTD_CFI_UTIL
tristate
- default y if MTD_CFI_INTELEXT=y || MTD_CFI_AMDSTD=y || MTD_CFI_STAA=y
- default m if MTD_CFI_INTELEXT=m || MTD_CFI_AMDSTD=m || MTD_CFI_STAA=m
config MTD_RAM
tristate "Support for RAM chips in bus mapping"
--- linux-2.6.10-rc2-mm3-full/drivers/mtd/devices/Kconfig.old 2004-11-28 23:44:18.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/mtd/devices/Kconfig 2004-11-28 23:50:46.000000000 +0100
@@ -130,6 +130,8 @@
config MTD_DOC2000
tristate "M-Systems Disk-On-Chip 2000 and Millennium (DEPRECATED)"
depends on MTD
+ select MTD_DOCPROBE
+ select MTD_NAND_IDS
---help---
This provides an MTD device driver for the M-Systems DiskOnChip
2000 and Millennium devices. Originally designed for the DiskOnChip
@@ -151,6 +153,8 @@
config MTD_DOC2001
tristate "M-Systems Disk-On-Chip Millennium-only alternative driver (DEPRECATED)"
depends on MTD
+ select MTD_DOCPROBE
+ select MTD_NAND_IDS
---help---
This provides an alternative MTD device driver for the M-Systems
DiskOnChip Millennium devices. Use this if you have problems with
@@ -171,6 +175,8 @@
config MTD_DOC2001PLUS
tristate "M-Systems Disk-On-Chip Millennium Plus"
depends on MTD
+ select MTD_DOCPROBE
+ select MTD_NAND_IDS
---help---
This provides an MTD device driver for the M-Systems DiskOnChip
Millennium Plus devices.
@@ -186,17 +192,10 @@
config MTD_DOCPROBE
tristate
- default m if MTD_DOC2001!=y && MTD_DOC2000!=y && MTD_DOC2001PLUS!=y && (MTD_DOC2001=m || MTD_DOC2000=m || MTD_DOC2001PLUS=m)
- default y if MTD_DOC2001=y || MTD_DOC2000=y || MTD_DOC2001PLUS=y
- help
- This isn't a real config option; it's derived.
+ select MTD_DOCECC
config MTD_DOCECC
tristate
- default m if MTD_DOCPROBE=m
- default y if MTD_DOCPROBE=y
- help
- This isn't a real config option; it's derived.
config MTD_DOCPROBE_ADVANCED
bool "Advanced detection options for DiskOnChip"
--- linux-2.6.10-rc2-mm3-full/drivers/mtd/nand/Kconfig.old 2004-11-28 23:44:33.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/mtd/nand/Kconfig 2004-11-28 23:53:30.000000000 +0100
@@ -7,6 +7,7 @@
config MTD_NAND
tristate "NAND Device Support"
depends on MTD
+ select MTD_NAND_IDS
help
This enables support for accessing all type of NAND flash
devices. For further information see
@@ -56,8 +57,6 @@
config MTD_NAND_IDS
tristate
- default y if MTD_NAND = y || MTD_DOC2000 = y || MTD_DOC2001 = y || MTD_DOC2001PLUS = y
- default m if MTD_NAND = m || MTD_DOC2000 = m || MTD_DOC2001 = m || MTD_DOC2001PLUS = m
config MTD_NAND_TX4925NDFMC
tristate "SmartMedia Card on Toshiba RBTX4925 reference board"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] select for drivers/mtd
2004-11-28 22:56 [2.6 patch] select for drivers/mtd Adrian Bunk
@ 2004-11-29 23:04 ` David Woodhouse
0 siblings, 0 replies; 4+ messages in thread
From: David Woodhouse @ 2004-11-29 23:04 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-mtd, linux-kernel
On Sun, 2004-11-28 at 23:56 +0100, Adrian Bunk wrote:
> The patch below switches options to use select where appropriate.
Thanks. Applied to bk://linux-mtd.bkbits.net/mtd-2.6 to go in after
2.6.10
> One of the dependencies of MTD_GEN_PROBE was on MTD_INTELPROBE that
> isn't in Linus' tree. If this symbol is present in the mtd cvs, a
> similar select is needed there.
It's gone now; removing it was correct.
> What's the purpose of the MTD_DOCECC option, which has always the same
> value as the MTD_DOCPROBE option?
It's obsolescent. The new DiskOnChip hardware driver was recently
converted from using it, in favour of the new Reed-Solomon library code.
Some day relatively soon the old hardware driver can go too, but not
yet. It's probably not worth converting that to the new ECC code.
--
dwmw2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-11-29 23:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-28 22:56 [2.6 patch] select for drivers/mtd Adrian Bunk
2004-11-29 23:04 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2003-09-28 15:38 Adrian Bunk
2003-09-28 16:00 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox