public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@engr.sgi.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix ROM enable/disable in r128 and radeon fb drivers
Date: Tue, 14 Dec 2004 14:20:12 -0800	[thread overview]
Message-ID: <200412141420.12863.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <9e4733910412141345380559da@mail.gmail.com>

On Tuesday, December 14, 2004 1:45 pm, Jon Smirl wrote:
> These drivers should be using the new ROM API in the PCI driver
> instead of manipulating the ROMs directly. Now that the ROM API is in
> the kernel all direct use of PCI_ENABLE_ROM should be removed. There
> are about thirty places in the kernel doing direct access. Kernel
> janitors would probably be a good place to track removing
> PCI_ENABLE_ROM.

Sure... but in the meantime the drivers should probably be trivially fixed 
like this so things don't break.

Thanks,
Jesse

  reply	other threads:[~2004-12-14 22:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-14 20:56 [PATCH] fix ROM enable/disable in r128 and radeon fb drivers Jesse Barnes
2004-12-14 21:45 ` Jon Smirl
2004-12-14 22:20   ` Jesse Barnes [this message]
2004-12-23 18:15     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200412141420.12863.jbarnes@engr.sgi.com \
    --to=jbarnes@engr.sgi.com \
    --cc=akpm@osdl.org \
    --cc=jonsmirl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox