cyrix_arr_init and centaur_mcr

The Linux Kernel Mailing List
 help / color / mirror / Atom feed

* cyrix_arr_init and centaur_mcr_init unused?
@ 2005-02-26 21:50 Andries.Brouwer
  2005-03-01 23:29 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Andries.Brouwer @ 2005-02-26 21:50 UTC (permalink / raw)
  To: linux-kernel

arch/i386/kernel/cpu/mtrr/cyrix.c has a routine cyrix_arr_init(), and
arch/i386/kernel/cpu/mtrr/centaur.c has a routine centaur_mcr_init().
At first sight it looks like these are unused.
Do I overlook something?

(They occur as the .init fields of some struct, and I did not find any
calls of ->init().)

If there are no calls and the code is needed, then some systems
may be broken today. If the code is not needed, maybe it should
be removed.

Andries

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: cyrix_arr_init and centaur_mcr_init unused?
  2005-02-26 21:50 cyrix_arr_init and centaur_mcr_init unused? Andries.Brouwer
@ 2005-03-01 23:29 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2005-03-01 23:29 UTC (permalink / raw)
  To: Andries.Brouwer; +Cc: Linux Kernel Mailing List

On Sad, 2005-02-26 at 21:50, Andries.Brouwer@cwi.nl wrote:
> arch/i386/kernel/cpu/mtrr/cyrix.c has a routine cyrix_arr_init(), and
> arch/i386/kernel/cpu/mtrr/centaur.c has a routine centaur_mcr_init().
> At first sight it looks like these are unused.
> Do I overlook something?
> 
> (They occur as the .init fields of some struct, and I did not find any
> calls of ->init().)

Does look like a bug to me - and the centaur code definitely wants the
mcr init function to be called.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-03-01 23:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-26 21:50 cyrix_arr_init and centaur_mcr_init unused? Andries.Brouwer
2005-03-01 23:29 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox