Re: [PATCH] sparc: fix compile failure ("struct resource" related)

Re: [PATCH] sparc: fix compile failure ("struct resource" related)

[Andrew Morton]

Alexey Dobriyan <adobriyan@mail.ru> wrote:
>
> Signed-off-by: Alexey Dobriyan <adobriyan@mail.ru>

Thanks.  Many of these fixups are due to a 64-bit-resource patch in Greg's
bk-pci tree which he has now reverted.  That being said:

- That patch will come back sometime

- Fixes like the below make sense anyway and can be merged any time.

- All the fixes which were only applicable when the 64-bit-resource patch
  is present have been sent to Greg for when that patch reemerges.


> --- linux-2.6.11-rc5-mm1/arch/sparc/kernel/ioport.c.orig	2005-03-01 21:11:30.000000000 +0200
> +++ linux-2.6.11-rc5-mm1/arch/sparc/kernel/ioport.c	2005-03-01 21:12:48.000000000 +0200
> @@ -54,11 +54,11 @@ static void _sparc_free_io(struct resour
>  
>  /* This points to the next to use virtual memory for DVMA mappings */
>  static struct resource _sparc_dvma = {
> -	"sparc_dvma", DVMA_VADDR, DVMA_END - 1
> +	.name = "sparc_dvma", .start = DVMA_VADDR, .end = DVMA_END - 1
>  };
>  /* This points to the start of I/O mappings, cluable from outside. */
>  /*ext*/ struct resource sparc_iomap = {
> -	"sparc_iomap", IOBASE_VADDR, IOBASE_END - 1
> +	.name = "sparc_iomap", .start = IOBASE_VADDR, .end = IOBASE_END - 1
>  };
>  
>  /*

Re: [PATCH] sparc: fix compile failure ("struct resource" related)

[William Lee Irwin III]

On Tue, Mar 01, 2005 at 01:44:40PM -0800, Andrew Morton wrote:
> Thanks.  Many of these fixups are due to a 64-bit-resource patch in Greg's
> bk-pci tree which he has now reverted.  That being said:
> - That patch will come back sometime
> - Fixes like the below make sense anyway and can be merged any time.
> - All the fixes which were only applicable when the 64-bit-resource patch
>   is present have been sent to Greg for when that patch reemerges.

Well, in isolation it's a C99 initializer cleanup, which is good.

Acked-by: William Irwin <wli@holomorphy.com>


-- wli