* [PATCH] Fix warning in gkc (make gconfig) {Scanned}
@ 2005-03-09 8:36 Romain Lievin
2005-03-12 21:15 ` Sam Ravnborg
0 siblings, 1 reply; 4+ messages in thread
From: Romain Lievin @ 2005-03-09 8:36 UTC (permalink / raw)
To: linux-kernel; +Cc: zippel
Hi,
this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc
(the GTK Kernel Configurator).
Please apply.
Thanks, Romain.
Signed-off-by: Romain Liévin <lkml@lievin.net>
================[cut here]====================
diff -Naur linux-2.6.11-rc3/scripts/kconfig/gconf.c linux/scripts/kconfig/gconf.c
--- linux-2.6.11-rc3/scripts/kconfig/gconf.c 2005-02-11 20:41:34.000000000 +0100
+++ linux/scripts/kconfig/gconf.c 2005-02-11 20:43:23.000000000 +0100
@@ -222,15 +222,15 @@
switch (view_mode) {
case SINGLE_VIEW:
widget = glade_xml_get_widget(xml, "button4");
- gtk_button_clicked(GTK_BUTTON(widget));
+ g_signal_emit_by_name(widget, "clicked");
break;
case SPLIT_VIEW:
widget = glade_xml_get_widget(xml, "button5");
- gtk_button_clicked(GTK_BUTTON(widget));
+ g_signal_emit_by_name(widget, "clicked");
break;
case FULL_VIEW:
widget = glade_xml_get_widget(xml, "button6");
- gtk_button_clicked(GTK_BUTTON(widget));
+ g_signal_emit_by_name(widget, "clicked");
break;
}
================[cut here]====================
--
Romain Liévin : <roms@lievin.net>
Web site : http://www.lievin.net
"Linux, y'a moins bien mais c'est plus cher !"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix warning in gkc (make gconfig) {Scanned}
2005-03-09 8:36 [PATCH] Fix warning in gkc (make gconfig) {Scanned} Romain Lievin
@ 2005-03-12 21:15 ` Sam Ravnborg
2005-03-13 5:46 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Sam Ravnborg @ 2005-03-12 21:15 UTC (permalink / raw)
To: Romain Lievin; +Cc: linux-kernel, zippel
On Wed, Mar 09, 2005 at 09:36:12AM +0100, Romain Lievin wrote:
> Hi,
>
> this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc
> (the GTK Kernel Configurator).
Applied, 2 warnings fixed - 10 more to go.
Care to take a look at them?
Also gconfig does not support setting localversion - is this something you
can fix too?
Sam
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix warning in gkc (make gconfig) {Scanned}
2005-03-12 21:15 ` Sam Ravnborg
@ 2005-03-13 5:46 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2005-03-13 5:46 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: lkml, linux-kernel, zippel
Sam Ravnborg <sam@ravnborg.org> wrote:
>
> On Wed, Mar 09, 2005 at 09:36:12AM +0100, Romain Lievin wrote:
> > Hi,
> >
> > this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc
> > (the GTK Kernel Configurator).
>
> Applied, 2 warnings fixed - 10 more to go.
> Care to take a look at them?
> Also gconfig does not support setting localversion - is this something you
> can fix too?
>
fyi, gconfig doesn't display those cute little pixmap buttons any more.
That bug was introduced by the patch "make gconfig work with gtk-2.4".
I'm planning on simply reverting that patch. Which should motivate someone
to have another go at fixing it for gtk2.4.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Fix warning in gkc (make gconfig) {Scanned}
@ 2005-02-11 19:47 Romain Lievin
0 siblings, 0 replies; 4+ messages in thread
From: Romain Lievin @ 2005-02-11 19:47 UTC (permalink / raw)
To: linux-kernel; +Cc: zippel
[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]
Hi,
this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc (the GTK Kernel Configurator).
Please apply.
Thanks, Romain.
Signed-off-by: Romain Liévin <lkml@lievin.net>
================[cut here]====================
diff -Naur linux-2.6.11-rc3/scripts/kconfig/gconf.c linux/scripts/kconfig/gconf.c
--- linux-2.6.11-rc3/scripts/kconfig/gconf.c 2005-02-11 20:41:34.000000000 +0100
+++ linux/scripts/kconfig/gconf.c 2005-02-11 20:43:23.000000000 +0100
@@ -222,15 +222,15 @@
switch (view_mode) {
case SINGLE_VIEW:
widget = glade_xml_get_widget(xml, "button4");
- gtk_button_clicked(GTK_BUTTON(widget));
+ g_signal_emit_by_name(widget, "clicked");
break;
case SPLIT_VIEW:
widget = glade_xml_get_widget(xml, "button5");
- gtk_button_clicked(GTK_BUTTON(widget));
+ g_signal_emit_by_name(widget, "clicked");
break;
case FULL_VIEW:
widget = glade_xml_get_widget(xml, "button6");
- gtk_button_clicked(GTK_BUTTON(widget));
+ g_signal_emit_by_name(widget, "clicked");
break;
}
================[cut here]====================
--
Romain Liévin : <roms@lievin.net>
Web site : http://www.lievin.net
"Linux, y'a moins bien mais c'est plus cher !"
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 785 bytes --]
diff -Naur linux-2.6.11-rc3/scripts/kconfig/gconf.c linux/scripts/kconfig/gconf.c
--- linux-2.6.11-rc3/scripts/kconfig/gconf.c 2005-02-11 20:41:34.000000000 +0100
+++ linux/scripts/kconfig/gconf.c 2005-02-11 20:43:23.000000000 +0100
@@ -222,15 +222,15 @@
switch (view_mode) {
case SINGLE_VIEW:
widget = glade_xml_get_widget(xml, "button4");
- gtk_button_clicked(GTK_BUTTON(widget));
+ g_signal_emit_by_name(widget, "clicked");
break;
case SPLIT_VIEW:
widget = glade_xml_get_widget(xml, "button5");
- gtk_button_clicked(GTK_BUTTON(widget));
+ g_signal_emit_by_name(widget, "clicked");
break;
case FULL_VIEW:
widget = glade_xml_get_widget(xml, "button6");
- gtk_button_clicked(GTK_BUTTON(widget));
+ g_signal_emit_by_name(widget, "clicked");
break;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-03-13 5:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-09 8:36 [PATCH] Fix warning in gkc (make gconfig) {Scanned} Romain Lievin
2005-03-12 21:15 ` Sam Ravnborg
2005-03-13 5:46 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2005-02-11 19:47 Romain Lievin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox