The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Rik van Riel <riel@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Keir Fraser <Keir.Fraser@cl.cam.ac.uk>,
	linux-kernel@vger.kernel.org, akpm@osdl.org, kurt@garloff.de,
	Ian.Pratt@cl.cam.ac.uk, Christian.Limpach@cl.cam.ac.uk
Subject: Re: [PATCH] Xen/i386 cleanups - AGP bus/phys cleanups
Date: Wed, 16 Mar 2005 18:10:42 +0000	[thread overview]
Message-ID: <20050316181042.GA26788@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0503160959530.4104@chimarrao.boston.redhat.com>

On Wed, Mar 16, 2005 at 10:01:07AM -0500, Rik van Riel wrote:
> In the case of AGP, the AGPGART effectively _is_ the
> IOMMU.  Calculating the addresses right for programming
> the AGPGART is probably worth fixing.

Well, it's a half-assed one.  And some systems have a real one.

But the real problem is that virt_to_bus doesn't exist at all
on architectures like ppc64, and this patch touches files like
generic.c and backend.c that aren't PC-specific.   So you
effectively break agp support for them.


  reply	other threads:[~2005-03-16 18:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-16 11:48 [PATCH] Xen/i386 cleanups - AGP bus/phys cleanups Keir Fraser
2005-03-16 14:31 ` Christoph Hellwig
2005-03-16 14:58   ` Keir Fraser
2005-03-16 15:01   ` Rik van Riel
2005-03-16 18:10     ` Christoph Hellwig [this message]
2005-03-16 18:35       ` Keir Fraser
2005-03-16 18:42         ` Jesse Barnes
2005-03-16 19:08           ` Keir Fraser
2005-03-16 19:06         ` Christoph Hellwig
2005-03-16 19:11           ` Keir Fraser
2005-03-16 17:40   ` Alan Cox
2005-03-16 17:54 ` Jesse Barnes
2005-03-16 21:24 ` Paul Mackerras
2005-03-16 22:06   ` Jesse Barnes
2005-03-16 23:55     ` Rik van Riel
2005-03-17  0:39       ` Paul Mackerras
2005-03-17  1:05         ` Tupshin Harper
2005-03-17  3:44         ` Rik van Riel
2005-03-17  4:42       ` Christoph Hellwig
2005-03-17  4:58         ` Rik van Riel
2005-03-17  9:16     ` Keir Fraser
2005-03-17  9:34       ` Paul Mackerras
2005-03-17 10:56         ` Keir Fraser
2005-03-19 10:07           ` Eric W. Biederman
2005-03-19 10:56             ` Christian Limpach
2005-03-19 13:01               ` Keir Fraser
2005-03-17 13:53         ` Alan Cox
2005-03-18  0:16           ` Paul Mackerras
2005-03-18  4:23             ` Rik van Riel
2005-03-18  9:05             ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050316181042.GA26788@infradead.org \
    --to=hch@infradead.org \
    --cc=Christian.Limpach@cl.cam.ac.uk \
    --cc=Ian.Pratt@cl.cam.ac.uk \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=kurt@garloff.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox