From: Russell King <rmk+lkml@arm.linux.org.uk>
To: takata@linux-m32r.org, akpm@osdl.org,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Bitrotting serial drivers
Date: Sat, 19 Mar 2005 17:21:01 +0000 [thread overview]
Message-ID: <20050319172101.C23907@flint.arm.linux.org.uk> (raw)
Hi,
m32r_sio
--------
Maintainer: Hirokazu Takata
Please clean up the m32r_sio driver, removing whatever bits of code
aren't absolutely necessary.
Specifically, I'd like to see the following addressed:
- the usage of SERIAL_IO_HUB6
(this driver doesn't support hub6 cards)
- SERIAL_IO_* should be UPIO_*
- __register_m32r_sio, register_m32r_sio, unregister_m32r_sio,
m32r_sio_get_irq_map
(this driver doesn't support PCMCIA cards, all of which are based on
8250-compatible devices.)
- early_serial_setup
(should we really have the function name duplicated across different
hardware drivers?)
au1x00_uart
-----------
Maintainer: unknown (akpm - any ideas?)
This is a complete clone of 8250.c, which includes all the 8250-specific
structure names.
Specifically, I'd like to see the following addressed:
- Please clean this up to use au1x00-specific names.
- this driver is lagging behind with fixes that the other drivers are
getting. Is au1x00_uart actually maintained?
- the usage of UPIO_HUB6
(this driver doesn't support hub6 cards)
- __register_serial, register_serial, unregister_serial
(this driver doesn't support PCMCIA cards, all of which are based on
8250-compatible devices.)
- early_serial_setup
(should we really have the function name duplicated across different
hardware drivers?)
The main reason is I wish to kill off uart_register_port and
uart_unregister_port, but these drivers are using it.
Thanks.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next reply other threads:[~2005-03-19 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 17:21 Russell King [this message]
2005-03-19 22:13 ` Bitrotting serial drivers Andrew Morton
2005-03-20 22:40 ` Ralf Baechle
2005-03-20 22:51 ` Pete Popov
2005-03-20 23:24 ` Russell King
2005-03-20 23:42 ` Pete Popov
2005-03-22 9:58 ` Michael Stickel
2005-03-24 10:14 ` [PATCH] " Hirokazu Takata
2005-03-24 12:17 ` Russell King
2005-03-25 9:07 ` Hirokazu Takata
2005-03-30 0:59 ` [PATCH 2.6.12-rc1-mm3] m32r: m32r_sio driver update (was Re: [PATCH] Re: Bitrotting serial drivers) Hirokazu Takata
2005-03-30 8:56 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050319172101.C23907@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=takata@linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox