From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Hirokazu Takata <takata@linux-m32r.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: Bitrotting serial drivers
Date: Thu, 24 Mar 2005 12:17:46 +0000 [thread overview]
Message-ID: <20050324121746.A4189@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050324.191424.233669632.takata.hirokazu@renesas.com>; from takata@linux-m32r.org on Thu, Mar 24, 2005 at 07:14:24PM +0900
On Thu, Mar 24, 2005 at 07:14:24PM +0900, Hirokazu Takata wrote:
> Could you please accept the following patch?
Probably, but I'd like to have a reply to my comments below first.
> diff -ruNp a/include/asm-m32r/serial.h b/include/asm-m32r/serial.h
> --- a/include/asm-m32r/serial.h 2004-12-25 06:35:40.000000000 +0900
> +++ b/include/asm-m32r/serial.h 2005-03-24 17:25:05.812651363 +0900
Can m32r accept PCMCIA cards? If so, this may mean that 8250.c gets
built, which will use this file to determine where it should look for
built-in 8250 ports.
If this file is used to describe non-8250 compatible ports, you could
end up with a nasty mess. Therefore, I recommend that you do not use
asm-m32r/serial.h to describe your SIO ports.
Instead, since these definitions are private to your own driver, you
may consider moving them into the driver, or a header file closely
associated with your driver in drivers/serial.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-03-24 12:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 17:21 Bitrotting serial drivers Russell King
2005-03-19 22:13 ` Andrew Morton
2005-03-20 22:40 ` Ralf Baechle
2005-03-20 22:51 ` Pete Popov
2005-03-20 23:24 ` Russell King
2005-03-20 23:42 ` Pete Popov
2005-03-22 9:58 ` Michael Stickel
2005-03-24 10:14 ` [PATCH] " Hirokazu Takata
2005-03-24 12:17 ` Russell King [this message]
2005-03-25 9:07 ` Hirokazu Takata
2005-03-30 0:59 ` [PATCH 2.6.12-rc1-mm3] m32r: m32r_sio driver update (was Re: [PATCH] Re: Bitrotting serial drivers) Hirokazu Takata
2005-03-30 8:56 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050324121746.A4189@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=takata@linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox