2.6.12-rc1-mm2 - ppc32 build fails.

2.6.12-rc1-mm2 - ppc32 build fails.

[cliff white]

Error message:

  CC      arch/ppc/kernel/setup.o
In file included from arch/ppc/kernel/setup.c:43:
include/asm/ppc_sys.h:29:2: #error "need definition of ppc_sys_devices"
In file included from arch/ppc/kernel/setup.c:43:
include/asm/ppc_sys.h:61: warning: parameter has incomplete type
include/asm/ppc_sys.h:64: warning: parameter has incomplete type
make[1]: *** [arch/ppc/kernel/setup.o] Error 1
make: *** [arch/ppc/kernel] Error 2

This fails for my config, and also for a defconfig build. 
We're thinking the patch 
"[PATCH] ppc32: PowerQUICC II Pro subarch support" 
( http://seclists.org/lists/linux-kernel/2005/Mar/1661.html )
may have hosed up the config, but haven't got that patch to cleanly revert yet.

cliffw

-- 
"Ive always gone through periods where I bolt upright at four in the morning; 
now at least theres a reason." -Michael Feldman

Re: 2.6.12-rc1-mm2 - ppc32 build fails.

[Andrew Morton]

cliff white <cliffw@osdl.org> wrote:
>
> 
> Error message:
> 
>   CC      arch/ppc/kernel/setup.o
> In file included from arch/ppc/kernel/setup.c:43:
> include/asm/ppc_sys.h:29:2: #error "need definition of ppc_sys_devices"
> In file included from arch/ppc/kernel/setup.c:43:
> include/asm/ppc_sys.h:61: warning: parameter has incomplete type
> include/asm/ppc_sys.h:64: warning: parameter has incomplete type

This should fix it.


From: Kumar Gala <galak@freescale.com>


Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 25-akpm/arch/ppc/kernel/setup.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletion(-)

diff -puN arch/ppc/kernel/setup.c~ppc32-report-chipset-version-in-common-proc-cpuinfo-handling-fix arch/ppc/kernel/setup.c
--- 25/arch/ppc/kernel/setup.c~ppc32-report-chipset-version-in-common-proc-cpuinfo-handling-fix	2005-03-24 12:27:39.000000000 -0800
+++ 25-akpm/arch/ppc/kernel/setup.c	2005-03-24 12:27:39.000000000 -0800
@@ -40,7 +40,10 @@
 #include <asm/nvram.h>
 #include <asm/xmon.h>
 #include <asm/ocp.h>
+
+#if defined(CONFIG_85xx) || defined(CONFIG_83xx)
 #include <asm/ppc_sys.h>
+#endif
 
 #if defined CONFIG_KGDB
 #include <asm/kgdb.h>
@@ -247,7 +250,7 @@ int show_cpuinfo(struct seq_file *m, voi
 	seq_printf(m, "bogomips\t: %lu.%02lu\n",
 		   lpj / (500000/HZ), (lpj / (5000/HZ)) % 100);
 
-#if defined (CONFIG_85xx) || defined (CONFIG_83xx)
+#if defined(CONFIG_85xx) || defined(CONFIG_83xx)
 	if (cur_ppc_sys_spec->ppc_sys_name)
 		seq_printf(m, "chipset\t\t: %s\n",
 			cur_ppc_sys_spec->ppc_sys_name);
_

Re: 2.6.12-rc1-mm2 - ppc32 build fails.

[cliff white]

On Thu, 24 Mar 2005 12:28:08 -0800
Andrew Morton <akpm@osdl.org> wrote:

> cliff white <cliffw@osdl.org> wrote:
> >
> > 
> > Error message:
> > 
> >   CC      arch/ppc/kernel/setup.o
> > In file included from arch/ppc/kernel/setup.c:43:
> > include/asm/ppc_sys.h:29:2: #error "need definition of ppc_sys_devices"
> > In file included from arch/ppc/kernel/setup.c:43:
> > include/asm/ppc_sys.h:61: warning: parameter has incomplete type
> > include/asm/ppc_sys.h:64: warning: parameter has incomplete type
> 
> This should fix it.

Fixes that problem, now i hit the kernel OOPS at drm initalization. 
Thought i saw a patch somewhere already for that...
cliffw

> 
> 
> From: Kumar Gala <galak@freescale.com>
> 
> 
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
> 
>  25-akpm/arch/ppc/kernel/setup.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff -puN arch/ppc/kernel/setup.c~ppc32-report-chipset-version-in-common-proc-cpuinfo-handling-fix arch/ppc/kernel/setup.c
> --- 25/arch/ppc/kernel/setup.c~ppc32-report-chipset-version-in-common-proc-cpuinfo-handling-fix	2005-03-24 12:27:39.000000000 -0800
> +++ 25-akpm/arch/ppc/kernel/setup.c	2005-03-24 12:27:39.000000000 -0800
> @@ -40,7 +40,10 @@
>  #include <asm/nvram.h>
>  #include <asm/xmon.h>
>  #include <asm/ocp.h>
> +
> +#if defined(CONFIG_85xx) || defined(CONFIG_83xx)
>  #include <asm/ppc_sys.h>
> +#endif
>  
>  #if defined CONFIG_KGDB
>  #include <asm/kgdb.h>
> @@ -247,7 +250,7 @@ int show_cpuinfo(struct seq_file *m, voi
>  	seq_printf(m, "bogomips\t: %lu.%02lu\n",
>  		   lpj / (500000/HZ), (lpj / (5000/HZ)) % 100);
>  
> -#if defined (CONFIG_85xx) || defined (CONFIG_83xx)
> +#if defined(CONFIG_85xx) || defined(CONFIG_83xx)
>  	if (cur_ppc_sys_spec->ppc_sys_name)
>  		seq_printf(m, "chipset\t\t: %s\n",
>  			cur_ppc_sys_spec->ppc_sys_name);
> _
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


-- 
"Ive always gone through periods where I bolt upright at four in the morning; 
now at least theres a reason." -Michael Feldman