From: Adrian Bunk <bunk@stusta.de>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: Steve French <smfrench@austin.rr.com>,
Steven French <sfrench@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] cifs: cleanup asn1.c - kfree
Date: Fri, 8 Apr 2005 00:06:22 +0200 [thread overview]
Message-ID: <20050407220622.GE4325@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0504042300520.2496@dragon.hyggekrogen.localhost>
On Mon, Apr 04, 2005 at 11:01:45PM +0200, Jesper Juhl wrote:
> Remove redundant NULL pointer check before calling kfree().
>
> Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
>
>
> --- linux-2.6.12-rc1-mm4/fs/cifs/asn1.c.with_patch1 2005-04-04 22:25:50.000000000 +0200
> +++ linux-2.6.12-rc1-mm4/fs/cifs/asn1.c 2005-04-04 22:33:34.000000000 +0200
> @@ -540,7 +540,6 @@ int decode_negTokenInit(unsigned char *s
> *(oid + 3)));
> rc = compare_oid(oid, oidlen, NTLMSSP_OID,
> NTLMSSP_OID_LEN);
> - if(oid)
> kfree(oid);
> if (rc)
> use_ntlmssp = TRUE;
Please fix the indentation of the kfree after removing the if.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-04-07 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-04 21:01 [PATCH 2/4] cifs: cleanup asn1.c - kfree Jesper Juhl
2005-04-07 22:06 ` Adrian Bunk [this message]
2005-04-08 23:06 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050407220622.GE4325@stusta.de \
--to=bunk@stusta.de \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@us.ibm.com \
--cc=smfrench@austin.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox