* [PATCH 2/4] cifs: cleanup asn1.c - kfree
@ 2005-04-04 21:01 Jesper Juhl
2005-04-07 22:06 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2005-04-04 21:01 UTC (permalink / raw)
To: Steve French; +Cc: Steven French, linux-kernel
Remove redundant NULL pointer check before calling kfree().
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
--- linux-2.6.12-rc1-mm4/fs/cifs/asn1.c.with_patch1 2005-04-04 22:25:50.000000000 +0200
+++ linux-2.6.12-rc1-mm4/fs/cifs/asn1.c 2005-04-04 22:33:34.000000000 +0200
@@ -540,7 +540,6 @@ int decode_negTokenInit(unsigned char *s
*(oid + 3)));
rc = compare_oid(oid, oidlen, NTLMSSP_OID,
NTLMSSP_OID_LEN);
- if(oid)
kfree(oid);
if (rc)
use_ntlmssp = TRUE;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] cifs: cleanup asn1.c - kfree
2005-04-04 21:01 [PATCH 2/4] cifs: cleanup asn1.c - kfree Jesper Juhl
@ 2005-04-07 22:06 ` Adrian Bunk
2005-04-08 23:06 ` Jesper Juhl
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-04-07 22:06 UTC (permalink / raw)
To: Jesper Juhl; +Cc: Steve French, Steven French, linux-kernel
On Mon, Apr 04, 2005 at 11:01:45PM +0200, Jesper Juhl wrote:
> Remove redundant NULL pointer check before calling kfree().
>
> Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
>
>
> --- linux-2.6.12-rc1-mm4/fs/cifs/asn1.c.with_patch1 2005-04-04 22:25:50.000000000 +0200
> +++ linux-2.6.12-rc1-mm4/fs/cifs/asn1.c 2005-04-04 22:33:34.000000000 +0200
> @@ -540,7 +540,6 @@ int decode_negTokenInit(unsigned char *s
> *(oid + 3)));
> rc = compare_oid(oid, oidlen, NTLMSSP_OID,
> NTLMSSP_OID_LEN);
> - if(oid)
> kfree(oid);
> if (rc)
> use_ntlmssp = TRUE;
Please fix the indentation of the kfree after removing the if.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/4] cifs: cleanup asn1.c - kfree
2005-04-07 22:06 ` Adrian Bunk
@ 2005-04-08 23:06 ` Jesper Juhl
0 siblings, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2005-04-08 23:06 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Steve French, Steven French, linux-kernel
On Fri, 8 Apr 2005, Adrian Bunk wrote:
> On Mon, Apr 04, 2005 at 11:01:45PM +0200, Jesper Juhl wrote:
> > Remove redundant NULL pointer check before calling kfree().
> >
> > Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
> >
> >
> > --- linux-2.6.12-rc1-mm4/fs/cifs/asn1.c.with_patch1 2005-04-04 22:25:50.000000000 +0200
> > +++ linux-2.6.12-rc1-mm4/fs/cifs/asn1.c 2005-04-04 22:33:34.000000000 +0200
> > @@ -540,7 +540,6 @@ int decode_negTokenInit(unsigned char *s
> > *(oid + 3)));
> > rc = compare_oid(oid, oidlen, NTLMSSP_OID,
> > NTLMSSP_OID_LEN);
> > - if(oid)
> > kfree(oid);
> > if (rc)
> > use_ntlmssp = TRUE;
>
>
> Please fix the indentation of the kfree after removing the if.
>
I do, in the next patch in the series, the
"fs_cifs_asn1-spacing-and-long-lines.patch" patch. That one fixes the
indentation along with lots of other whitespace issues.
--
Jesper Juhl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-04-08 23:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-04 21:01 [PATCH 2/4] cifs: cleanup asn1.c - kfree Jesper Juhl
2005-04-07 22:06 ` Adrian Bunk
2005-04-08 23:06 ` Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox