From: Joel Becker <Joel.Becker@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hangcheck-timer: Update to 0.9.0.
Date: Tue, 12 Apr 2005 17:38:04 -0700 [thread overview]
Message-ID: <20050413003804.GJ31163@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20050412171801.444df4bc.akpm@osdl.org>
On Tue, Apr 12, 2005 at 05:18:01PM -0700, Andrew Morton wrote:
> It's not very important, but it would be a bit more conventional to use
> CONFIG_X86, CONFIG_ARCH_S390, CONFIG_IA64 and CONFIG_PPC64 for those cases
> where such an ifdef is to be used.
Well, yeah, silly me.
> Joel Becker <Joel.Becker@oracle.com> wrote:
> > +# define TIMER_FREQ 1000000000ULL
> > +# define TIMER_FREQ 0xFA240000ULL
> > +# define TIMER_FREQ ((unsigned long long)local_cpu_data->itc_freq)
> > +# define TIMER_FREQ (HZ*loops_per_jiffy)
>
> In the above case specifically, no ifdefs should be needed - you can simply
> define CONFIG_HANGCHECK_TIMER_FREQ in arch/*/Kconfig.
Kbuild foo help, please. I can't quite figure out how to
represent the non-constant values as code in Kbuild. I can represent
them as strings, but then they are strings, not code.
Joel
--
Life's Little Instruction Book #452
"Never compromise your integrity."
Joel Becker
Senior Member of Technical Staff
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2005-04-13 0:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 23:50 [PATCH] hangcheck-timer: Update to 0.9.0 Joel Becker
2005-04-13 0:18 ` Andrew Morton
2005-04-13 0:38 ` Joel Becker [this message]
2005-04-13 0:47 ` Andrew Morton
2005-04-14 23:43 ` Joel Becker
[not found] <200505011707.j41H7VbY021843@hera.kernel.org>
2005-05-01 17:45 ` Arjan van de Ven
2005-05-02 8:48 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050413003804.GJ31163@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox