From: Joel Becker <Joel.Becker@oracle.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hangcheck-timer: Update to 0.9.0.
Date: Mon, 2 May 2005 01:48:55 -0700 [thread overview]
Message-ID: <20050502084855.GQ4747@ca-server1.us.oracle.com> (raw)
In-Reply-To: <1114969538.6577.21.camel@localhost.localdomain>
On Sun, May 01, 2005 at 01:45:37PM -0400, Arjan van de Ven wrote:
> > +
> > +#if defined(CONFIG_X86) || defined(CONFIG_X86_64)
> > +# define HAVE_MONOTONIC
> > +# define TIMER_FREQ 1000000000ULL
>
> this looks wrong!
>
> does this work with HZ=100 ?
> also there is a TSC config option which you want to use most likely
> instead of CONFIG_X86 (and x86-64 has CONFIG_X86 defined too)
It is right, though. monotonic_clock() is defined as returning
nanoseconds, not a value based on HZ. It's supported on x86 and x86-64,
hence using CONFIG_X86 to check. Someday, John will get it implemented
for the other platforms, and we'll have less mess in hangcheck-timer.c.
He already thinks that he should have the prototype in timer.h or so (so
I don't have to extern declare it), but he hasn't gotten around to it
yet.
Joel
--
Life's Little Instruction Book #30
"Never buy a house without a fireplace."
Joel Becker
Senior Member of Technical Staff
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2005-05-02 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200505011707.j41H7VbY021843@hera.kernel.org>
2005-05-01 17:45 ` [PATCH] hangcheck-timer: Update to 0.9.0 Arjan van de Ven
2005-05-02 8:48 ` Joel Becker [this message]
2005-04-12 23:50 Joel Becker
2005-04-13 0:18 ` Andrew Morton
2005-04-13 0:38 ` Joel Becker
2005-04-13 0:47 ` Andrew Morton
2005-04-14 23:43 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050502084855.GQ4747@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox