2.6.12.2 acpi_register_gsi() patch causes problems on Asus A7V333 motherboard

2.6.12.2 acpi_register_gsi() patch causes problems on Asus A7V333 motherboard

[Tomasz Lemiech]

Hello,

Today I tried 2.6.12.2 on an Asus A7V333 (socket A) with AMD Duron 1300 
MHz CPU and noticed, that the system clock was running about 60 times 
faster than real time and the keyboard was unresponsive. However, I was 
able to log in remotely and collect some standard debugging info (dmesg, 
lspci, interrupts, config), which is available at 
http://szpajder.w.staszic.waw.pl/a7v333/ . Summary of my quick research 
follows:

- 2.6.12.1 works without problems

- 2.6.12.2 with acpi=off works without problems

- 2.6.12.2 with acpi_register_gsi() one-line fix works without problems

I was using Asus BIOS revision 1012 and also tried to upgrade to the 
latest 1017 with no luck.

Please Cc: any replies, because I'm not subscribed to the list. Thanks.

Regards,

-- 
 			     	 Tomasz Lemiech (RLU#189399) (TL4681-RIPE)
 				  <szpajder@staszic.waw.pl> [GG:3786250]

Re: 2.6.12.2 acpi_register_gsi() patch causes problems on Asus A7V333 motherboard

[Chris Wright]

* Tomasz Lemiech (szpajder@staszic.waw.pl) wrote:
> Today I tried 2.6.12.2 on an Asus A7V333 (socket A) with AMD Duron 1300 
> MHz CPU and noticed, that the system clock was running about 60 times 
> faster than real time and the keyboard was unresponsive. However, I was 
> able to log in remotely and collect some standard debugging info (dmesg, 
> lspci, interrupts, config), which is available at 
> http://szpajder.w.staszic.waw.pl/a7v333/ . Summary of my quick research 
> follows:
> 
> - 2.6.12.1 works without problems
> 
> - 2.6.12.2 with acpi=off works without problems
> 
> - 2.6.12.2 with acpi_register_gsi() one-line fix works without problems

One line fix means the 's/>= 0/> 0/' ?  If so, that's currently queued to
the -stable tree and should be present in the forthcoming .3.  If not,
could you please clarify what the one line fix is?

thanks,
-chris

Re: 2.6.12.2 acpi_register_gsi() patch causes problems on Asus A7V333 motherboard

[Tomasz Lemiech]

On Tue, 12 Jul 2005, Chris Wright wrote:

>> - 2.6.12.2 with acpi_register_gsi() one-line fix works without problems

My apologies - I meant: "_without_ acpi_register_gsi() one-line fix". That 
is, _reverting_
http://www.kernel.org/git/?p=linux/kernel/git/gregkh/linux-2.6.12.y.git;a=commit;h=1ef0867a529b222b8ff659d68140df8d5d6a45f2
from 2.6.12.2 fixes the problem.

Thanks for your reply.

Regards,

-- 
 			     	 Tomasz Lemiech (RLU#189399) (TL4681-RIPE)
 				  <szpajder@staszic.waw.pl> [GG:3786250]

Re: 2.6.12.2 acpi_register_gsi() patch causes problems on Asus A7V333 motherboard

[Chris Wright]

* Tomasz Lemiech (szpajder@staszic.waw.pl) wrote:
> On Tue, 12 Jul 2005, Chris Wright wrote:
> 
> >>- 2.6.12.2 with acpi_register_gsi() one-line fix works without problems
> 
> My apologies - I meant: "_without_ acpi_register_gsi() one-line fix". That 
> is, _reverting_
> http://www.kernel.org/git/?p=linux/kernel/git/gregkh/linux-2.6.12.y.git;a=commit;h=1ef0867a529b222b8ff659d68140df8d5d6a45f2
> from 2.6.12.2 fixes the problem.

Can you verify that the patch below (w/out reverting that patch, apply
on top of) fixes it for you?

thanks,
-chris
--

---

 drivers/acpi/pci_irq.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -433,7 +433,7 @@ acpi_pci_irq_enable (
 		printk(KERN_WARNING PREFIX "PCI Interrupt %s[%c]: no GSI",
 			pci_name(dev), ('A' + pin));
 		/* Interrupt Line values above 0xF are forbidden */
-		if (dev->irq >= 0 && (dev->irq <= 0xF)) {
+		if (dev->irq > 0 && (dev->irq <= 0xF)) {
 			printk(" - using IRQ %d\n", dev->irq);
 			acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
 			return_VALUE(0);

Re: 2.6.12.2 acpi_register_gsi() patch causes problems on Asus A7V333 motherboard

[Tomasz Lemiech]

On Tue, 12 Jul 2005, Chris Wright wrote:

> * Tomasz Lemiech (szpajder@staszic.waw.pl) wrote:
>> On Tue, 12 Jul 2005, Chris Wright wrote:
>>
>>>> - 2.6.12.2 with acpi_register_gsi() one-line fix works without problems
>>
>> My apologies - I meant: "_without_ acpi_register_gsi() one-line fix". That
>> is, _reverting_
>> http://www.kernel.org/git/?p=linux/kernel/git/gregkh/linux-2.6.12.y.git;a=commit;h=1ef0867a529b222b8ff659d68140df8d5d6a45f2
>> from 2.6.12.2 fixes the problem.
>
> Can you verify that the patch below (w/out reverting that patch, apply
> on top of) fixes it for you?

Yup, it does, thanks much. Now I see that there was an earlier thread 
concerning the same problem. Sorry for extra noise.

Regards,

-- 
 			     	 Tomasz Lemiech (RLU#189399) (TL4681-RIPE)
 				  <szpajder@staszic.waw.pl> [GG:3786250]

Re: 2.6.12.2 acpi_register_gsi() patch causes problems on Asus A7V333 motherboard

[Chris Wright]

* Tomasz Lemiech (szpajder@staszic.waw.pl) wrote:
> Yup, it does, thanks much. Now I see that there was an earlier thread 
> concerning the same problem. Sorry for extra noise.

No problem, thanks for verifying.  That patch should be in .3, so I'm
happy to build up success cases with it.

thanks,
-chris