[2.6 patch] lib/sort.c: small cleanups

[2.6 patch] lib/sort.c: small cleanups

[Adrian Bunk]

This patch contains the following small cleanups:
- make two needlessly global functions static
- every file should #include the header files containing the prototypes 
  of it's global functions


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13-mm1-full/lib/sort.c.old	2005-09-03 14:02:17.000000000 +0200
+++ linux-2.6.13-mm1-full/lib/sort.c	2005-09-03 14:03:02.000000000 +0200
@@ -6,15 +6,16 @@
 
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/sort.h>
 
-void u32_swap(void *a, void *b, int size)
+static void u32_swap(void *a, void *b, int size)
 {
 	u32 t = *(u32 *)a;
 	*(u32 *)a = *(u32 *)b;
 	*(u32 *)b = t;
 }
 
-void generic_swap(void *a, void *b, int size)
+static void generic_swap(void *a, void *b, int size)
 {
 	char t;
 

Re: [2.6 patch] lib/sort.c: small cleanups

[Ingo Oeser]

On Saturday 03 September 2005 15:25, Adrian Bunk wrote:
> This patch contains the following small cleanups:
> - make two needlessly global functions static
> - every file should #include the header files containing the prototypes 
>   of it's global functions

While this is a nice cleanup, does anybody remember,
why the inner loops are duplicated in the source?

If there are no arguments for it, I would like to consolidate them
to a function or a define, if they share to much state.

Or is the duplicate just considered cleaner?


Regards

Ingo Oeser