From: Jesper Juhl <jesper.juhl@gmail.com>
To: "linux-kernel" <linux-kernel@vger.kernel.org>
Cc: Hariprasad Nellitheertha <hari@in.ibm.com>
Subject: [PATCH] disable_local_APIC() is only available when CONFIG_X86_LOCAL_APIC is defined
Date: Mon, 5 Sep 2005 01:57:52 +0200 [thread overview]
Message-ID: <200509050157.52344.jesper.juhl@gmail.com> (raw)
`disable_local_APIC' is only available when CONFIG_X86_LOCAL_APIC is defined :
arch/i386/kernel/crash.c: In function `crash_nmi_callback':
arch/i386/kernel/crash.c:153: warning: implicit declaration of function `disable_local_APIC'
arch/i386/kernel/crash.c: In function `nmi_shootdown_cpus':
arch/i386/kernel/crash.c:195: warning: implicit declaration of function `disable_local_APIC'
There may be a better fix, but the below seems to do the trick.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
--- linux-2.6.13-mm1-orig/arch/i386/kernel/crash.c 2005-09-02 23:59:27.000000000 +0200
+++ linux-2.6.13-mm1/arch/i386/kernel/crash.c 2005-09-05 01:54:21.000000000 +0200
@@ -150,7 +150,9 @@ static int crash_nmi_callback(struct pt_
regs = &fixed_regs;
}
crash_save_this_cpu(regs, cpu);
+#ifdef CONFIG_X86_LOCAL_APIC
disable_local_APIC();
+#endif
atomic_dec(&waiting_for_crash_ipi);
/* Assume hlt works */
halt();
@@ -190,7 +192,9 @@ static void nmi_shootdown_cpus(void)
}
/* Leave the nmi callback set */
+#ifdef CONFIG_X86_LOCAL_APIC
disable_local_APIC();
+#endif
}
#else
static void nmi_shootdown_cpus(void)
next reply other threads:[~2005-09-04 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-04 23:57 Jesper Juhl [this message]
2005-09-05 0:05 ` [PATCH] disable_local_APIC() is only available when CONFIG_X86_LOCAL_APIC is defined Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509050157.52344.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=hari@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox