From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Hariprasad Nellitheertha <hari@in.ibm.com>
Subject: Re: [PATCH] disable_local_APIC() is only available when CONFIG_X86_LOCAL_APIC is defined
Date: Mon, 5 Sep 2005 02:05:49 +0200 [thread overview]
Message-ID: <9a87484905090417057f755434@mail.gmail.com> (raw)
In-Reply-To: <200509050157.52344.jesper.juhl@gmail.com>
On 9/5/05, Jesper Juhl <jesper.juhl@gmail.com> wrote:
>
> `disable_local_APIC' is only available when CONFIG_X86_LOCAL_APIC is defined :
>
> arch/i386/kernel/crash.c: In function `crash_nmi_callback':
> arch/i386/kernel/crash.c:153: warning: implicit declaration of function `disable_local_APIC'
> arch/i386/kernel/crash.c: In function `nmi_shootdown_cpus':
> arch/i386/kernel/crash.c:195: warning: implicit declaration of function `disable_local_APIC'
>
> There may be a better fix, but the below seems to do the trick.
>
[snip]
I guess the better fix is to just provide a dummy function in the case
of CONFIG_X86_LOCAL_APIC not being defined.
If so, just let me know and I'll cook up a patch to do that, instead
of the ugly ifdef's.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
prev parent reply other threads:[~2005-09-05 0:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-04 23:57 [PATCH] disable_local_APIC() is only available when CONFIG_X86_LOCAL_APIC is defined Jesper Juhl
2005-09-05 0:05 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a87484905090417057f755434@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=hari@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox