[PATCH] disable_local_APIC() is only available when CONFIG_X86_LOCAL_APIC is defined

[PATCH] disable_local_APIC() is only available when CONFIG_X86_LOCAL_APIC is defined

[Jesper Juhl]

`disable_local_APIC' is only available when CONFIG_X86_LOCAL_APIC is defined :

arch/i386/kernel/crash.c: In function `crash_nmi_callback':
arch/i386/kernel/crash.c:153: warning: implicit declaration of function `disable_local_APIC'
arch/i386/kernel/crash.c: In function `nmi_shootdown_cpus':
arch/i386/kernel/crash.c:195: warning: implicit declaration of function `disable_local_APIC'

There may be a better fix, but the below seems to do the trick.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>

--- linux-2.6.13-mm1-orig/arch/i386/kernel/crash.c	2005-09-02 23:59:27.000000000 +0200
+++ linux-2.6.13-mm1/arch/i386/kernel/crash.c	2005-09-05 01:54:21.000000000 +0200
@@ -150,7 +150,9 @@ static int crash_nmi_callback(struct pt_
 		regs = &fixed_regs;
 	}
 	crash_save_this_cpu(regs, cpu);
+#ifdef CONFIG_X86_LOCAL_APIC
 	disable_local_APIC();
+#endif
 	atomic_dec(&waiting_for_crash_ipi);
 	/* Assume hlt works */
 	halt();
@@ -190,7 +192,9 @@ static void nmi_shootdown_cpus(void)
 	}
 
 	/* Leave the nmi callback set */
+#ifdef CONFIG_X86_LOCAL_APIC
 	disable_local_APIC();
+#endif
 }
 #else
 static void nmi_shootdown_cpus(void)

Re: [PATCH] disable_local_APIC() is only available when CONFIG_X86_LOCAL_APIC is defined

[Jesper Juhl]

On 9/5/05, Jesper Juhl <jesper.juhl@gmail.com> wrote:
> 
> `disable_local_APIC' is only available when CONFIG_X86_LOCAL_APIC is defined :
> 
> arch/i386/kernel/crash.c: In function `crash_nmi_callback':
> arch/i386/kernel/crash.c:153: warning: implicit declaration of function `disable_local_APIC'
> arch/i386/kernel/crash.c: In function `nmi_shootdown_cpus':
> arch/i386/kernel/crash.c:195: warning: implicit declaration of function `disable_local_APIC'
> 
> There may be a better fix, but the below seems to do the trick.
> 
[snip]

I guess the better fix is to just provide a dummy function in the case
of CONFIG_X86_LOCAL_APIC not being defined.
If so, just let me know and I'll cook up a patch to do that, instead
of the ugly ifdef's.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html